always use the new pump start logic

mck1117 · Jun 26, 2024 · 867082f · 867082f
1 parent e70df58
commit 867082f
Show file tree

Hide file tree

Showing 3 changed files with 7 additions and 10 deletions.
diff --git a/firmware/boards/f0_module/wideband_board_config.h b/firmware/boards/f0_module/wideband_board_config.h
@@ -17,9 +17,3 @@
 //    Nernst voltage & ESR sense
 // *******************************
 #define VM_RESISTOR_VALUE (10)
-
-// *******************************
-// Hack: allow pump driving above target temperature
-// minus this offset to avoid Vnerns voltage clamp near 0V
-// *******************************
-#define START_PUMP_TEMP_OFFSET	(200.0)
diff --git a/firmware/pump_control.cpp b/firmware/pump_control.cpp
@@ -39,10 +39,7 @@ static void PumpThread(void*)
 
             // Only actuate pump when running closed loop!
             if (heater.IsRunningClosedLoop() ||
-#ifdef START_PUMP_TEMP_OFFSET
-                (sampler.GetSensorTemperature() >= heater.GetTargetTemp() - START_PUMP_TEMP_OFFSET) ||
-#endif
-                (0))
+                (sampler.GetSensorTemperature() >= heater.GetTargetTemp() - START_PUMP_TEMP_OFFSET))
             {
                 float nernstVoltage = sampler.GetNernstDc();
 

diff --git a/firmware/wideband_config.h b/firmware/wideband_config.h
@@ -48,3 +48,9 @@
 #define HEATER_BATTERY_ON_VOLTAGE	9.5
 // mininal battery voltage to continue heating
 #define HEATER_BATTETY_OFF_VOLTAGE  8.5
+
+// *******************************
+// Start driving the pump just before we're at target temperature
+// minus this offset to avoid Vnerns voltage clamp near 0V
+// *******************************
+#define START_PUMP_TEMP_OFFSET	(200.0)