Heater #157
Open
Heater #157
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
See comments at #140 |
mck1117
reviewed
Sep 16, 2022
firmware/heater_control.cpp
Outdated
| SetFault(s.ch, Fault::SensorNoHeatSupply); | ||
| return HeaterState::NoHeaterSupply; | ||
| } | ||
| SetFault(s.ch, Fault::None); |
There was a problem hiding this comment.
do we really want to clear fault in case of heater not allowed? what if you cycle the ignition on, sensor has fault, you turn ignition off, then fault has disappeared?
There was a problem hiding this comment.
sounds like unit tests are needed :(
mck1117
reviewed
Nov 20, 2023
| if (batteryVoltage < HEATER_BATTETY_OFF_VOLTAGE) | ||
| { | ||
| SetFault(ch, Fault::SensorNoHeatSupply); | ||
| return HeaterState::NoHeaterSupply; |
There was a problem hiding this comment.
this code is unreachable because of line 51, no?
There was a problem hiding this comment.
@dron0gus I've just rebased this old PR but do we still need it at all?
There was a problem hiding this comment.
This maybe gets replaced by #292 with the addition of the SetFault(...) call near line 51
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.