Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

heater: 5 sec stabilization time after switching to closed loop #222

Open
wants to merge 1 commit into
base: master
Choose a base branch
from

Conversation

rusefillc
Copy link
Contributor

LSU4.2 falls to Underheated state right after switch to closed loop due to rise of sensorEsr (due to applied pump current?)

@mck1117
Copy link
Owner

mck1117 commented Mar 22, 2023

have a log?

@dron0gus
Copy link
Contributor

Or maybe this is caused by rapidly increased heater PWM? Unlikely.
Issue can also be solve by using hysteresis for underheatESR thresholds.
Screenshot from 2023-03-22 10-42-17
lsu42_heating.zip

@mck1117
Copy link
Owner

mck1117 commented Mar 22, 2023

That’s pretty strange. It makes me question the accuracy of the ESR measurement…

@mck1117
Copy link
Owner

mck1117 commented Mar 22, 2023

What happens if you postpone activating the pump until the sensor is fully warm?

@dron0gus
Copy link
Contributor

I'll do some testing later.

@dron0gus
Copy link
Contributor

Pump control enabled only after sensor reaches targetESR
Screenshot from 2023-03-23 00-43-54
lsu42_heating_mod.zip

@dron0gus
Copy link
Contributor

Looks like Nernst voltage is too low and AC component is clamped. This gives us lower ESR than actually it is.
When we start feeding pump with some current Nernst voltage get some shift from zero and AC component is measured correctly. This cause ESR rise/calculated temperature drop.
On dial rev1 I have added 0.3V shift to x3 Nernst voltage. Waiting for new HW to check if this helps.
Screenshot from 2023-03-23 00-48-17

@dron0gus
Copy link
Contributor

Yep, this is clamped Nernst.
Screenshot from 2023-03-23 01-11-36

@mck1117
Copy link
Owner

mck1117 commented Mar 22, 2023

seems like at least worth a comment explaining that finding

@dron0gus
Copy link
Contributor

Screenshot from 2023-04-16 13-25-46
Screenshot from 2023-04-16 13-25-00
But this is with
2023-04-16_13.21.46-rev1-warmup.zip
4.9. Needs additional testing with 4.2.

@dron0gus
Copy link
Contributor

Screenshot from 2023-04-16 13-34-15

@mck1117
Copy link
Owner

mck1117 commented Apr 17, 2023

So it seems the same bump up in ESR is still there on 4.9, but not as severe, so it doesn't trip underheat.

@rusefillc
Copy link
Contributor Author

Just rebased this one

@mck1117 @dron0gus are you guys more or less in agreement about this change? @dron0gus can you add additional code comments into this branch? @mck1117 any chance you would be able to merge and add desired code comments?

@rusefillc
Copy link
Contributor Author

@mck1117 this was rebased please revisit this PR (fails same as master, will rebase on master when master gets green)

LSU4.2 falls to Underheated state right after switch to closed loop
due to rise of sensorEsr (due to applied pump current?)
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants