Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

PHP 8.4 compatibility #69

Closed
wants to merge 1 commit into from
Closed

PHP 8.4 compatibility #69

wants to merge 1 commit into from

Conversation

andypost
Copy link

@andypost
Copy link
Author

Testing with official docker image docker run --rm -v $(pwd):/mnt -w /mnt php:8.4.0alpha2-cli-alpine find . -type f -name '*.php' -exec php -l {} \;

@mck89
Copy link
Owner

mck89 commented Jul 23, 2024

That would break the compatibility with PHP < 7 since nullable types were introduced in that version, it's not a big deal but i prefer to keep it until possibile. Maybe removing the type declaration just for this methods is enough, i will investigate it.

@mck89
Copy link
Owner

mck89 commented Jul 23, 2024

I've chosen to proceed in the way i described opening a new pull request #70, i'll close this one, thank you anyway!

@mck89 mck89 closed this Jul 23, 2024
@andypost andypost deleted the php84 branch July 23, 2024 16:51
@andypost
Copy link
Author

Thank you!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants