Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

LZ4 decompressor stop upon detect other SKIPPABLE frame! These frames should be ignored. #104

Closed
remittor opened this issue Nov 29, 2019 · 2 comments

Comments

@remittor
Copy link

https://github.com/lz4/lz4/blob/dev/doc/lz4_Frame_format.md#skippable-frames

4 Bytes, Little endian format. Value : 0x184D2A5X, which means any value from 0x184D2A50 to 0x184D2A5F. All 16 values are valid to identify a skippable frame.

Because of this, the 7zip-Zstd will only unpack its own archives.

Using mutexes only slows down LZ4 packer!!!

@remittor remittor changed the title LZ4 decompressor ignore other SKIPPABLE frames! It's bad practice! LZ4 decompressor stop upon detect other SKIPPABLE frame! These frames should be ignored. Nov 29, 2019
@mcmilk
Copy link
Owner

mcmilk commented Nov 30, 2019

Please don't use a ot of "!!!" - it's not nice.

I also think, that the code skips the skippable... if not, that would be really a bug in zstdmt code.

@mcmilk
Copy link
Owner

mcmilk commented Dec 21, 2019

Hello remittor, can you give some example for the bad behavior of zstdmt... if yes, then please re-open that issue here.

@mcmilk mcmilk closed this as completed Dec 21, 2019
mcmilk added a commit that referenced this issue Apr 10, 2020
mcmilk added a commit that referenced this issue Apr 10, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants