msgpack.decode() not working for chrome >=60

[peeyushsrj]

It's working fine for chrome versions, before 60. Also not working on latest firefox! Please do review decode() function.

[mcollina]

Can you please provide some cases to reproduce? Thanks!

[peeyushsrj]

You can check over here https://backbench.github.io/repl/. This works fine in chrome <= 59! This is repl for https://bblang.org

[mcollina]

I can see that. However all the unit test suite is passing locally on Chrome 60 with msgpack v3.5.0.

[peeyushsrj]

@mcollina I did changed to version 3.5.0 in console, still the same error. You can check yourself over https://backbench.github.io/repl/

[mcollina]

Can you reproduce without all of that?

[peeyushsrj]

I will try to.

[antlafarge]

Same bug, reproduced here in Chrome 60, Firefox 55 and Edge 40 : https://jsfiddle.net/antlafarge/wrjzt1zy/

[antlafarge]

The method BufferList.readUInt8(offset) returns always the first value of the internal buffer.

msgpack5/lib/decoder.js

Line 119 in 5fd4ef7

var first = buf.readUInt8(offset)

[mcollina]

So, is this a bug on bl?

I'm a bit lost, as the browser tests are passing.

[antlafarge]

Maybe, I'm not sure.
But I'm sure the lib is actually broken on most of the recent browsers.

[mcollina]

@antlafarge how are you including the library?

[antlafarge]

In my projects with <script src="./libs/msgpack5.js"></script>
In jsfiddle I did an "ugly" copy paste to avoid file hosting ^^

[mcollina]

Have you built that bundle yourself, or is it the one from this repo?

[antlafarge]

From this repo :)

[mcollina]

I just pushed an updated version of that bundle. Please check. Il giorno mar 29 ago 2017 alle 19:32 antlafarge <[email protected]> ha scritto:

…

From this repo :) — You are receiving this because you were mentioned. Reply to this email directly, view it on GitHub <#57 (comment)>, or mute the thread <https://github.com/notifications/unsubscribe-auth/AADL4xhFA1iNpzuDVN_wpTh3ZmGHCCvJks5sdATygaJpZM4O8-T9> .

[antlafarge]

msgpack5.js and msgpack5.min.js in the dist directory are unchanged. And I have the same problem.

[mcollina]

it's now pushed, please check.

[peeyushsrj]

@mcollina please do a release for current updates in msgpack5. As I am using cdn in production.

[mcollina]

v3.5.1 is published. Let me know how it goes.

[antlafarge]

Okay we get further. But there is a problem by decoding with a js array as parameter.
msgpack5().decode([146, 13, 37]); should result to [13, 37], but results to 49.

Here is the call stack :

> BufferList.prototype._appendBuffer( Uint8Array(3) [ 49, 52, 54 ] )
  BufferList.prototype.append( 146 )
  BufferList.prototype.append( [146, 13, 37] )
  msgpack5.decode( [146, 13, 37] )

Here the strange Buffer I got :

So my question : Is the js array as input always supported?

Edit : By using an array as input, I expect the BufferList uses the function fromArrayLike internally.

[antlafarge]

By using an Uint8Array as input, the IncompleteBufferError is gone and the result is correct.