Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Handle NaN #75

Merged
merged 2 commits into from
Sep 17, 2018
Merged
Show file tree
Hide file tree
Changes from all commits
Commits
File filter

Filter by extension

Filter by extension

Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
8 changes: 8 additions & 0 deletions lib/encoder.js
Original file line number Diff line number Diff line change
Expand Up @@ -10,6 +10,8 @@ module.exports = function buildEncode (encodingTypes, forceFloat64, compatibilit

if (obj === undefined) {
throw new Error('undefined is not encodable in msgpack!')
} else if (isNaN(obj)) {
throw new Error('NaN is not encodable in msgpack!')
} else if (obj === null) {
buf = Buffer.allocUnsafe(1)
buf[0] = 0xc0
Expand Down Expand Up @@ -303,6 +305,12 @@ function isFloat (n) {
return n % 1 !== 0
}

function isNaN (n) {
/* eslint-disable no-self-compare */
return n !== n && typeof n === 'number'
/* eslint-enable no-self-compare */
}

function encodeFloat (obj, forceFloat64) {
var useDoublePrecision = true

Expand Down
10 changes: 10 additions & 0 deletions test/15-elements-maps.js
Original file line number Diff line number Diff line change
Expand Up @@ -71,6 +71,16 @@ test('do not encode undefined in a map', function (t) {
t.end()
})

test('throw error on NaN in a map', function (t) {
var instance = msgpack()
var toEncode = { a: NaN, hello: 'world' }

t.throws(function () {
instance.encode(toEncode)
}, Error, 'must throw Error')
t.end()
})

test('encode/decode map with buf, ints and strings', function (t) {
var map = {
topic: 'hello',
Expand Down
14 changes: 14 additions & 0 deletions test/NaN.js
Original file line number Diff line number Diff line change
@@ -0,0 +1,14 @@
'use strict'

var test = require('tape').test
var msgpack = require('../')

test('encode NaN', function (t) {
var encoder = msgpack()

t.throws(function () {
encoder.encode(NaN)
}, Error, 'must throw Error')

t.end()
})