Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Allow NaN #94

Merged
merged 2 commits into from
Feb 11, 2021
Merged

Allow NaN #94

merged 2 commits into from
Feb 11, 2021

Conversation

ninevra
Copy link
Contributor

@ninevra ninevra commented Feb 11, 2021 •
edited
Loading

Allows encoding NaN, prefering float32 unless otherwise indicated.

Tests decoding, encoding, and round-tripping NaN.

Uses Object.is() in one place, breaking IE support; if that's something msgpack5 promises, it can be worked around.

Closes #93.

mcollina
mcollina approved these changes Feb 11, 2021
View reviewed changes
Copy link
Owner

@mcollina mcollina left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

lgtm

@mcollina mcollina merged commit e2788d0 into mcollina:master Feb 11, 2021
This was referenced Mar 12, 2021
Closed
Closed
Closed
Closed
Open
Closed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@mcollina mcollina mcollina approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

msgpack5 throws when encoding NaN, contrary to spec
2 participants
@ninevra @mcollina