feat: Add default export typings #59
Closed
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
"Prefix" before file number. Enables users to pattern their file name independently of number of log in current rotation.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Built on #58 -- adds Typescript typings for the default pino-roll export.
Unfortunately this is not ready to merge due to this library using CJS-style exports which cause issues with importing in ESM-style projects.
microsoft/TypeScript#52086
microsoft/TypeScript#53045
Possibly can be fixed by outputting different builds for esm and cjs and specifying in package.json (using something like tshy) or by updating this library to be ESM on a major version bump (breaking change).