Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Unit tests, fixes calculation of number size #7

Merged
merged 10 commits into from
Feb 3, 2019

Conversation

jmhummel
Copy link
Contributor

@jmhummel jmhummel commented Oct 5, 2018

Fixes number size calculation

Naming Rules and Data Types:

Numbers can be positive, negative, or zero. Numbers can have up to 38 digits precision. Exceeding this results in an exception.
Positive range: 1E-130 to 9.9999999999999999999999999999999999999E+125
Negative range: -9.9999999999999999999999999999999999999E+125 to -1E-130

Looking at this page in the documentation, I realized my previous implementation was incorrect, and 1 byte = 2 decimal digits. Which makes more sense, since "99" takes 7 bits to store. The other 1 byte needed holds the exponent.

  • Adds multiple unit tests for each value type
  • Updates CircleCI build node version to 8.10 (LTS)
  • Adds .gitignore
  • Added a CircleCI badge to the README, you'll likely want to change that in your fork to point to your CircleCI instead

@jmhummel
Copy link
Contributor Author

jmhummel commented Feb 1, 2019

@mcwhittemore

@mcwhittemore mcwhittemore merged commit cc9625d into mcwhittemore:master Feb 3, 2019
@mcwhittemore
Copy link
Owner

Thanks for the at mention. Merged and published in 0.3.1.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants