Fix pkg entry file for browser (compiled) #513
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Update with master
Fix to handle `import ejs from 'ejs'` within bundlers such as Webpack
|
Thank you! |
|
Heads up: I had to remove the "browser" property for Browserify to work when creating the most recent bugfix release. I haven't done the research to see how these work, but you'll need to make sure you can run the |
|
Also, I'm not sure the UMD module generated by Browserify is what we want to be specifying for all bundlers. This had some helpful info: https://github.com/defunctzombie/package-browser-field-spec |
|
@mde okay, I'll take a look |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fix to handle
import ejs from 'ejs'within bundlers such as Webpack.