-
Notifications
You must be signed in to change notification settings - Fork 841
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Fix #510. Remove jake dev dependency and embed arg parser. #645
Open
arthanzel
wants to merge
1
commit into
mde:main
Choose a base branch
from
arthanzel:510-embed-parseopts
base: main
Could not load branches
Branch not found: {{ refName }}
Loading
Could not load tags
Nothing to show
Loading
Are you sure you want to change the base?
Some commits from the old base branch may be removed from the timeline,
and old review comments may become outdated.
Open
Changes from all commits
Commits
File filter
Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
There are no files selected for viewing
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Original file line number | Diff line number | Diff line change |
---|---|---|
|
@@ -208,4 +208,105 @@ exports.createNullProtoObjWherePossible = (function () { | |
}; | ||
})(); | ||
|
||
// Embedded argument parser from https://github.com/jakejs/jake/blob/master/lib/parseargs.js | ||
// See original source for doc. | ||
// Fixes #510 and allows removing `jake` as a prod dependency. | ||
exports.parseArgs = function parseArgs(programOpts, programArgs) { | ||
let isOpt = function (arg) { | ||
return arg.indexOf('-') === 0; | ||
}; | ||
let removeOptPrefix = function (opt) { | ||
return opt.replace(/^--/, '').replace(/^-/, ''); | ||
}; | ||
|
||
const Parser = function (opts) { | ||
this.opts = {}; | ||
this.taskNames = null; | ||
this.envVars = null; | ||
this.reg = opts; | ||
this.shortOpts = {}; | ||
this.longOpts = {}; | ||
|
||
let self = this; | ||
[].forEach.call(opts, function (item) { | ||
self.shortOpts[item.abbr] = item; | ||
self.longOpts[item.full] = item; | ||
}); | ||
}; | ||
|
||
Parser.prototype = new (function () { | ||
let _trueOrNextVal = function (argParts, args) { | ||
if (argParts[1]) { | ||
return argParts[1]; | ||
} else { | ||
return !args[0] || isOpt(args[0]) ? true : args.shift(); | ||
} | ||
}; | ||
|
||
this.parse = function (args) { | ||
let cmds = []; | ||
let cmd; | ||
let envVars = {}; | ||
let opts = {}; | ||
let arg; | ||
let argItem; | ||
let argParts; | ||
let cmdItems; | ||
let taskNames = []; | ||
let preempt; | ||
|
||
while (args.length) { | ||
arg = args.shift(); | ||
|
||
if (isOpt(arg)) { | ||
arg = removeOptPrefix(arg); | ||
argParts = arg.split('='); | ||
argItem = this.longOpts[argParts[0]] || this.shortOpts[argParts[0]]; | ||
if (argItem) { | ||
There was a problem hiding this comment. Choose a reason for hiding this commentThe reason will be displayed to describe this comment to others. Learn more. If this condition does not meet, I. E. this is an unrecognized option, do we want to throw an error? See #690 |
||
// First-encountered preemptive opt takes precedence -- no further opts | ||
// or possibility of ambiguity, so just look for a value, or set to | ||
// true and then bail | ||
if (argItem.preempts) { | ||
opts[argItem.full] = _trueOrNextVal(argParts, args); | ||
preempt = true; | ||
break; | ||
} | ||
// If the opt requires a value, see if we can get a value from the | ||
// next arg, or infer true from no-arg -- if it's followed by another | ||
// opt, throw an error | ||
if (argItem.expectValue || argItem.allowValue) { | ||
opts[argItem.full] = _trueOrNextVal(argParts, args); | ||
if (argItem.expectValue && !opts[argItem.full]) { | ||
throw new Error(argItem.full + ' option expects a value.'); | ||
} | ||
} else { | ||
opts[argItem.full] = true; | ||
} | ||
} | ||
} else { | ||
cmds.unshift(arg); | ||
} | ||
} | ||
|
||
if (!preempt) { | ||
// Parse out any env-vars and task-name | ||
while ((cmd = cmds.pop())) { | ||
cmdItems = cmd.split('='); | ||
if (cmdItems.length > 1) { | ||
envVars[cmdItems[0]] = cmdItems[1]; | ||
} else { | ||
taskNames.push(cmd); | ||
} | ||
} | ||
} | ||
|
||
return { | ||
opts: opts, | ||
envVars: envVars, | ||
taskNames: taskNames, | ||
}; | ||
}; | ||
})(); | ||
|
||
return new Parser(programOpts).parse(programArgs); | ||
}; |
Some generated files are not rendered by default. Learn more about how customized files appear on GitHub.
Oops, something went wrong.
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
This may not matter, but you could just use one
replace
call by using the regex of/^--?/
as that means that the second hyphen is optional.There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
It also sorta sounds like this was just copy/pasted from jake, so I also understand this wasn't technically the op's code.