A web component for aggregate metrics #3
Closed
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
@rwaldron @lukebjerring: this is a follow-up to w3c#314, #1, #2 |
…__add-bq' onto 'abcd'
Hexcles
reviewed
Dec 12, 2017
|
Probably. I've found merging and/or rebasing this string of PRs to be
rather error-prone.
…On Tue, Dec 12, 2017, 1:51 PM Robert Ma, ***@***.***> wrote:
***@***.**** commented on this pull request.
Did you accidentally switch back to the old Firefox logo?
—
You are receiving this because you authored the thread.
Reply to this email directly, view it on GitHub
<#3 (review)>,
or mute the thread
<https://github.com/notifications/unsubscribe-auth/ABsWSEED6KBlr-MIu-oP1IrfgseKLpyJks5s_ssUgaJpZM4Q6Mme>
.
|
|
Firefox logo fixed now. |
|
PR is running @ https://metrics5-dot-wptdashboard.appspot.com/metrics/ |
lukebjerring
reviewed
Jan 9, 2018
| @@ -103,6 +103,21 @@ func (ctx GCSDatastoreContext) Output(id OutputId, metadata interface{}, | |||
| log.Printf("Writing %s to Google Cloud Storage\n", name) | |||
| gcsData := GCSData{metadata, data} | |||
| obj := ctx.Bucket.Handle.Object(id.DataLocation.GCSObjectPath) | |||
| objWriter := obj.NewWriter(ctx.Context) | |||
There was a problem hiding this comment.
This change seems unrelated - can it be moved into another PR?
There was a problem hiding this comment.
Sure. I'll pull it out when I request review under w3c/wptdashboard
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR integrates a link to the
/metrics/route, which mirrors the structure of the/route, but shows a table of metrics rather than test results.There is some duplication of patterns from
wpt-results.html, but I feel the implementations are different enough that it's not worth doing anything fancy with inheritance.