Use file manager for uploading images #20
Conversation
|
Question: Do you prefer pull requests or issues in the moodle tracker for changes like this? |
|
Tracker Issue: https://tracker.moodle.org/browse/CONTRIB-4087 |
|
Hi jk3us, tracker is nice as I may forget about the github issue. :) I am going to have to test this on my local machine and look at the code before I merge it into the this repository. Sorry for the delay. I will be dedicating some more of my time shortly into tracker issues for the certificate. |
|
That's fine, the more testing the better. Let me know if there's something that could be done better. I'd also like to work on the option uploading images in the mod_form itself if you have a very specific certificate. Also, svg images, since I think the version of tcpdf that ships with Moodle 2.4 handles them better than before. |
|
Hey, has anything been done with this change? I just had to upload some new borders and was reminded that this change would be nice to have :) |
|
Hi Jay, any free time I have to develop I spend on the new certificate module I am creating (https://github.com/markn86/moodle-mod_customcert) which has this functionality but still is under development and not ready yet. If you are happy to rebase your changes I promise to look at this asap and provide feedback. |
|
TBH, this got lost in the backlog of issues to do for the certificate module which I have been neglecting to take on due to any free time spent on the new module. |
|
I will try to rebase soon, but I will also take a look at the new cert module. Do you have any description or screenshots of it and how it's different? Any ideas of when it will be ready to release? |
|
Hi Jay, I actually gave a talk about it at the moodlemoot. Please see http://www.youtube.com/watch?v=NNnoIUUC2pA#t=18m30s and https://moodle.org/mod/forum/discuss.php?d=229683 for reference. |
|
Hi Jay, Hi Mark. Any updates on this PR? Can anything be done to help? Thanks! |
|
I have a new job where I'm not working with moodle anymore, so I don't think I'll be able to do any more with this. |
This change uses Moodle's nice file_storage mechanism for management uploaded images.
In the upload_image_form.php form, instead of a dropdown for type and a single file picker, that form now has a file_manager for each image type (border, seal, etc), you can drag multiple files into each and delete old files. (it lets you delete files that are in use, be careful!)
In the mod_form, it lists files that are in the codebase and in this the proper file area (but no longer the hardcoded data_dir directory *)
When generating the pdf, files in the file area get pulled and inserted appropriately.
I can hopefully add the upgrade migration part and test some more next week, but wanted to send this along since I won't be looking at this again until after new year. Feel free to test and provide feedback, or go ahead and do my unfinished work for me :)