Change Android WebView from 1 to ≤37 for API N-T #10653

queengooborg · 2021-05-27T17:10:23Z

A general rule of thumb that I heard and have been going by when updating BCD for WebView Android is that anything added in Chrome 1 will be present in WebView Android 1. However, looking at the difference in WebKit versions (528 for Chrome 1 vs. 523.12 for WebView Android 1), it's simply not plausible that this statement is true -- and after getting my hands on an Android 1.0 emulator, I've confirmed my suspicions. A more accurate rule of thumb would be that "anything present in Safari 3 will be in WebView Android 1".

This PR changes various entries set to WebView Android 1.0 to our range of ≤37 instead after running the mdn-bcd-collector in Android 1.0 and comparing the results to our data. I plan to follow up and replace these ranged values with proper version numbers in the future.

foolip · 2021-06-01T08:22:43Z

api/SVGTRefElement.json

@@ -44,7 +44,7 @@
            "version_removed": "2.0"
          },
          "webview_android": {
-            "version_added": "1",
+            "version_added": "≤37",


Due to mdn/yari#3238 this is going to end up looking broken on MDN. This was in Safari 1, so I'm guessing it was enabled with the rest of SVG in some early version of Android WebView? Can you identify that version to avoid this looking broken?

Unfortunately I don't have access to many old Android versions at the moment, only 1.0, 1.5, and 4.4, so I can't determine a specific version yet...

foolip · 2021-06-01T08:27:47Z

api/SVGAnimateColorElement.json

@@ -44,7 +44,7 @@
            "version_removed": "2.0"
          },
          "webview_android": {
-            "version_added": "1",
+            "version_added": "≤37",


This and other cases with "version_removed": "37" will end up looking broken on MDN due to mdn/yari#3238. It's not so broken that I think it has to change, but if you can find the right version for this now, that would be better.

foolip · 2021-06-01T09:28:06Z

For the SVG stuff, can you run npm run traverse webview_android all 1 | grep -i svg to ensure nothing is left? #10564 just changed some data that I think will need to be updated too.

Support for requiredExtensions and systemLanguage in WebKit goes back to when SVG was first shipped: https://trac.webkit.org/browser/webkit/tags/old/Safari-522.11.1b/WebCore/ksvg2/svg/SVGTests.idl https://trac.webkit.org/browser/webkit/branches/old/Safari-3-branch/WebCore/ksvg2/svg/SVGTests.idl Support for SVGTests was added in Firefox 12: https://developer.mozilla.org/en-US/docs/Mozilla/Firefox/Releases/12#svg WebView ≤37 is used to match mdn#10653. mdn-bcd-collector has tests: http://mdn-bcd-collector.appspot.com/tests/api/SVGAnimationElement/requiredExtensions http://mdn-bcd-collector.appspot.com/tests/api/SVGAnimationElement/systemLanguage http://mdn-bcd-collector.appspot.com/tests/api/SVGGraphicsElement/requiredExtensions http://mdn-bcd-collector.appspot.com/tests/api/SVGGraphicsElement/systemLanguage These weren't used to confirm the data since it goes so far back, but mdn-bcd-collector at least doesn't constradict any of the added data.

Support for requiredExtensions and systemLanguage in WebKit goes back to when SVG was first shipped: https://trac.webkit.org/browser/webkit/tags/old/Safari-522.11.1b/WebCore/ksvg2/svg/SVGTests.idl https://trac.webkit.org/browser/webkit/branches/old/Safari-3-branch/WebCore/ksvg2/svg/SVGTests.idl Support for SVGTests was added in Firefox 12: https://developer.mozilla.org/en-US/docs/Mozilla/Firefox/Releases/12#svg WebView ≤37 is used to match #10653. mdn-bcd-collector has tests: http://mdn-bcd-collector.appspot.com/tests/api/SVGAnimationElement/requiredExtensions http://mdn-bcd-collector.appspot.com/tests/api/SVGAnimationElement/systemLanguage http://mdn-bcd-collector.appspot.com/tests/api/SVGGraphicsElement/requiredExtensions http://mdn-bcd-collector.appspot.com/tests/api/SVGGraphicsElement/systemLanguage These weren't used to confirm the data since it goes so far back, but mdn-bcd-collector at least doesn't constradict any of the added data.

foolip · 2021-06-02T07:33:39Z

I've sent #10710 and running that against this PR would yield these errors:

Problems in 5 files:
✖ api/SVGAnimateColorElement.json
  Versions – 1 error:
  → api.SVGAnimateColorElement - version_removed: "37" must be greater than version_added: "≤37"
✖ api/SVGGraphicsElement.json
  Versions – 1 error:
  → api.SVGGraphicsElement - version_removed: "4.4" must be greater than version_added: "≤37"
✖ api/SVGSVGElement.json
  Versions – 2 errors:
  → api.SVGSVGElement.contentScriptType - version_removed: "37" must be greater than version_added: "≤37"
  → api.SVGSVGElement.contentStyleType - version_removed: "37" must be greater than version_added: "≤37"
✖ api/SVGTRefElement.json
  Versions – 1 error:
  → api.SVGTRefElement - version_removed: "4.4.3" must be greater than version_added: "≤37"
✖ api/SVGUseElement.json
  Versions – 2 errors:
  → api.SVGUseElement.animatedInstanceRoot - version_removed: "37" must be greater than version_added: "≤37"
  → api.SVGUseElement.instanceRoot - version_removed: "37" must be greater than version_added: "≤37"

I would suggest leaving those as "1" with an issue pointing out which entries are still known to be wrong, along with instructions (npm run traverse webview_android all 1 | grep -i svg) for checking if any more incorrect data has been added before the issue is resolved.

foolip · 2021-06-02T07:34:00Z

But also, some of these entries can probably be removed to sidestep the whole problem.

foolip · 2021-06-02T07:43:18Z

I've sent #10714 for one piece that can be dropped.

foolip · 2021-06-03T11:21:30Z

Remaining lint errors if applying #10710:

Problems in 4 files:
✖ api/SVGAnimateColorElement.json
  Versions – 1 error:
  → api.SVGAnimateColorElement - version_removed: "37" must be greater than version_added: "≤37"
✖ api/SVGGraphicsElement.json
  Versions – 1 error:
  → api.SVGGraphicsElement - version_removed: "4.4" must be greater than version_added: "≤37"
✖ api/SVGSVGElement.json
  Versions – 2 errors:
  → api.SVGSVGElement.contentScriptType - version_removed: "37" must be greater than version_added: "≤37"
  → api.SVGSVGElement.contentStyleType - version_removed: "37" must be greater than version_added: "≤37"
✖ api/SVGTRefElement.json
  Versions – 1 error:
  → api.SVGTRefElement - version_removed: "4.4.3" must be greater than version_added: "≤37"

Since these have all been removed, I'd suggest leaving added as "1" and filing an issue about getting the right initial version for SVG in WebView, which involves updating both these remaining 1s and a lot of the new ≤37s.

queengooborg · 2021-06-06T02:29:25Z

I've opened #10790 to discuss this, and will revert the linter-conflicting changes for the time being, until I can find a way to test those other WebView versions!

Change Android WebView from 1 to ≤37 for API N-T

9187860

github-actions bot added the data:api 🐇 Compat data for Web APIs. https://developer.mozilla.org/docs/Web/API label May 27, 2021

foolip requested changes Jun 1, 2021

View reviewed changes

queengooborg self-assigned this Jun 1, 2021

foolip mentioned this pull request Jun 1, 2021

Demix SVGTests to SVGAnimationElement and SVGGraphicsElement #10691

Merged

queengooborg added 2 commits June 1, 2021 22:19

Merge branch 'main' into api/webview-1-to-range-n-t

ba3c0ea

Correct remaining SVG APIs

a823aed

foolip mentioned this pull request Jun 2, 2021

Require added+removed versions to make sense when ignoring ranges #10710

Merged

queengooborg added 2 commits June 3, 2021 03:16

Merge branch 'main' into api/webview-1-to-range-n-t

b441f76

Remove accidentally-added file

9c4c155

Revert changes conflicting with mdn#10710

0767a69

foolip approved these changes Jun 6, 2021

View reviewed changes

foolip merged commit 21a90d1 into mdn:main Jun 6, 2021

queengooborg deleted the api/webview-1-to-range-n-t branch June 6, 2021 09:30

fabb mentioned this pull request Jun 6, 2021

-webkit-overflow-scrolling no longer supported in iOS 13+ #10542

Merged

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

Change Android WebView from 1 to ≤37 for API N-T #10653

Change Android WebView from 1 to ≤37 for API N-T #10653

queengooborg commented May 27, 2021

foolip Jun 1, 2021

queengooborg Jun 2, 2021

foolip Jun 1, 2021

foolip commented Jun 1, 2021

foolip commented Jun 2, 2021

foolip commented Jun 2, 2021

foolip commented Jun 2, 2021

foolip commented Jun 3, 2021

queengooborg commented Jun 6, 2021

Change Android WebView from 1 to ≤37 for API N-T #10653

Change Android WebView from 1 to ≤37 for API N-T #10653

Conversation

queengooborg commented May 27, 2021

foolip Jun 1, 2021

Choose a reason for hiding this comment

queengooborg Jun 2, 2021

Choose a reason for hiding this comment

foolip Jun 1, 2021

Choose a reason for hiding this comment

foolip commented Jun 1, 2021

foolip commented Jun 2, 2021

foolip commented Jun 2, 2021

foolip commented Jun 2, 2021

foolip commented Jun 3, 2021

queengooborg commented Jun 6, 2021