Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Rename entry for FormData.append's filename parameter #10695

Merged
merged 1 commit into from
Jun 2, 2021

Conversation

foolip
Copy link
Collaborator

@foolip foolip commented Jun 1, 2021

This is more consistent with many foo_parameter entries, such as
api.Element.requestFullscreen.options_parameter.

Importantly, including an underscore makes it clear that it's not an
exposed name of an API.

@foolip foolip requested a review from ddbeck June 1, 2021 11:44
@github-actions github-actions bot added the data:api 🐇 Compat data for Web APIs. https://developer.mozilla.org/docs/Web/API label Jun 1, 2021
@@ -153,9 +153,9 @@
"deprecated": false
}
},
"AppendWithFilename": {
"filename_argument": {
Copy link
Collaborator

@ddbeck ddbeck Jun 1, 2021

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Nice! This is the kind of thing that I was trying to tackle with this new guideline: https://github.com/mdn/browser-compat-data/blob/main/docs/data-guidelines.md#parameters-and-parameter-object-features. Want to change this to use "parameter" instead of "argument"?

Copy link
Collaborator Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Since you ask I have to say I don't quite want to use "parameter", since the "argument" terminology is baked into the platform itself, but consistency always wins and I see there are more foo_parameter than foo_argument entries in BCD. So I'll fall in line :)

Copy link
Collaborator Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

And pushing the rest of the data into line as well: #10700

Copy link
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Yeah, "want" was probably the wrong word (I also thought it should've been argument, #10509, but MDN uses parameter far more often). Thank you!

@foolip foolip changed the title Rename entry for FormData.append's filename argument Rename entry for FormData.append's filename parameter Jun 1, 2021
This is more consistent with many foo_parameter entries, such as
api.Element.requestFullscreen.options_parameter.

Importantly, including an underscore makes it clear that it's not an
exposed name of an API.
@ddbeck ddbeck merged commit 436634e into mdn:main Jun 2, 2021
@foolip foolip deleted the filename_argument branch June 2, 2021 11:19
ddbeck added a commit to ddbeck/browser-compat-data that referenced this pull request Jun 2, 2021
ddbeck added a commit to ddbeck/browser-compat-data that referenced this pull request Jun 3, 2021
ddbeck added a commit that referenced this pull request Jun 4, 2021
* Bump version to v3.3.6
* Add release note for #10646
* Add release note for #10581
* Add release note for #10685
* Add release note for #10691
* Add release note for #6957
* Add release note for #10721
* Add release note for #10695
* Add release note for #9821
* Add release note for #10681
* Add release note for #10725
* Add stats
* Add release date
* Wordsmith
foolip added a commit to foolip/browser-compat-data that referenced this pull request Oct 20, 2021
queengooborg pushed a commit that referenced this pull request Oct 23, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
data:api 🐇 Compat data for Web APIs. https://developer.mozilla.org/docs/Web/API
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants