Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Demix SVGAnimatedPoints to SVGPolygonElement and SVGPolylineElement #10698

Merged
merged 1 commit into from
Jun 2, 2021

Conversation

foolip
Copy link
Collaborator

@foolip foolip commented Jun 1, 2021

@github-actions github-actions bot added the data:api 🐇 Compat data for Web APIs. https://developer.mozilla.org/docs/Web/API label Jun 1, 2021
@foolip foolip requested a review from Elchi3 June 1, 2021 12:35
Copy link
Member

@Elchi3 Elchi3 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good to me. It would be good to add spec_urls, though. Thank you! :)

Tests:
http://mdn-bcd-collector.appspot.com/tests/api/SVGPolygonElement
http://mdn-bcd-collector.appspot.com/tests/api/SVGPolylineElement

Since this is so old, mdn-bcd-collector can't be used to fill in the
exact versions. Instead, the data for <polygon> and <polyline> was
assumed to be largely correct.
@foolip
Copy link
Collaborator Author

foolip commented Jun 1, 2021

spec_urls added!

Copy link
Member

@Elchi3 Elchi3 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

tack 👍

@Elchi3 Elchi3 merged commit 56c40a3 into mdn:main Jun 2, 2021
@foolip foolip deleted the rm-SVGAnimatedPoints branch June 2, 2021 06:48
@foolip
Copy link
Collaborator Author

foolip commented Jun 2, 2021

mdn/content#5181 is the MDN side of this.

ddbeck added a commit to ddbeck/browser-compat-data that referenced this pull request Jun 9, 2021
@ddbeck
Copy link
Collaborator

ddbeck commented Jun 9, 2021

Sorry, I missed this one in last week's release notes. I opened #10893 to go back and add it.

ddbeck added a commit that referenced this pull request Jun 10, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
data:api 🐇 Compat data for Web APIs. https://developer.mozilla.org/docs/Web/API
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants