Update data for BeforeInstallPrompt event #12856
Conversation
This PR adds real values for Chromium (Chrome, Opera, Samsung Internet, WebView Android) for the `onbeforeinstallprompt` member of the `Window` API, based upon results from the [mdn-bcd-collector](https://mdn-bcd-collector.appspot.com) project (v3.3.0). Tests Used: https://mdn-bcd-collector.appspot.com/tests/api/Window/onbeforeinstallprompt _Check out the [collector's guide on how to review this PR](https://github.com/foolip/mdn-bcd-collector#reviewing-bcd-changes)._
github-actions
bot
added
the
data:api 🐇
|
Lint is still failing, it seems. |
ah sorry, my fault — I only just now realized that https://wicg.github.io/manifest-incubations/ is a raw respec spec. That means I have to add it to the list of such specs in my tooling. After I do that and re-run the build, it should work. It’ll take about 30 minutes to run. I’ll post an update here when it’s done. |
|
Well, I fixed the problem I mentioned, and so that’s all working now — but the problem is this:
|
queengooborg
added
the
not ready ⛔
queengooborg
removed
the
not ready ⛔
|
Because this PR affects real values, I don't want the spec URL to get in the way of us reaching our real value goals, so I went ahead and removed them. The other event in the spec, |
api/Window.json
Outdated
| "description": "<code>beforeinstallprompt</code> event", | ||
| "support": { | ||
| "chrome": { | ||
| "version_added": "45" |
There was a problem hiding this comment.
Given #7844 I especially distrust Chrome 45 values so I dug deeper.
The feature was enabled by https://chromium.googlesource.com/chromium/src/+/e9e94d1355522e4e4a5a8aa2f540d265130ab98c which via https://www.chromium.org/developers/calendar maps to Chrome 44, although it's so close to the branch date it could have been 45.
But I've also tested logging BeforeInstallPromptEvent in BrowserStack, and can see that it was introduced in Chrome 44.
Can you update the data for BeforeInstallPromptEvent to 44 and also update this to match?
queengooborg
changed the title
This PR adds real values for Chromium (Chrome, Opera, Samsung Internet, WebView Android) for the
onbeforeinstallpromptmember of theWindowAPI, based upon results from the mdn-bcd-collector project (v3.3.0).Tests Used: https://mdn-bcd-collector.appspot.com/tests/api/Window/onbeforeinstallprompt
Check out the collector's guide on how to review this PR.