-
Notifications
You must be signed in to change notification settings - Fork 2k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Conform gamepad Window events to new style; update Chromium versions #14038
Conform gamepad Window events to new style; update Chromium versions #14038
Conversation
This PR updates and corrects the real values for Microsoft Edge for the `ongamepadconnected` and `ongamepaddisconnected` members of the `Window` API, based upon results from the [mdn-bcd-collector](https://mdn-bcd-collector.appspot.com) project (v4.0.0). Tests Used: https://mdn-bcd-collector.appspot.com/tests/api/Window/ongamepadconnected _Check out the [collector's guide on how to review this PR](https://github.com/foolip/mdn-bcd-collector#reviewing-bcd-changes)._
@queengooborg the Edge data doesn't match Chrome still. And should we just go ahead and merge the event entries here, so that @Elchi3 doesn't need to combine the data in a second step soon? How should we capture a missing event handler property? |
For the avoidance of doubt, I'd still like to see the event entries merge and for that to be reviewed by @Elchi3. |
Happy to review merged events, yes. |
For other reviewers for future archeologists, the evidence for this change is here: |
Co-authored-by: Philip Jägenstedt <[email protected]>
This PR updates and corrects the real values for Chromium for the
ongamepadconnected
andongamepaddisconnected
members of theWindow
API, based upon results from the mdn-bcd-collector project (v4.0.0).Tests Used: https://mdn-bcd-collector.appspot.com/tests/api/Window/ongamepadconnected
Check out the collector's guide on how to review the version changes of this PR.
This PR also merges the event handles with the events to conform to the new style.
Content PR: mdn/content#12933