Update History pushstate|replacestate note about “unused” param (was “title”) #15149
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…“title”) Related MDN change: mdn/content#13322 Related spec bug: whatwg/html#6482 Relevant spec sections: - https://html.spec.whatwg.org/multipage/history.html#dom-history-pushstate - https://html.spec.whatwg.org/multipage/history.html#dom-history-replacestate - https://html.spec.whatwg.org/multipage/history.html#dom-history-pushstate-dev - https://html.spec.whatwg.org/multipage/history.html#dom-history-replacestate-dev
github-actions
bot
added
the
data:api 🐇
ddbeck
reviewed
Mar 8, 2022
api/History.json
Outdated
| @@ -296,7 +296,7 @@ | |||
| }, | |||
| "title_parameter": { | |||
There was a problem hiding this comment.
Is there a reason you didn't rename the features themselves?
There was a problem hiding this comment.
Is there a reason you didn't rename the features themselves?
Nope, it was just an oversight/miss — thanks for catching that
sideshowbarker
commented
Mar 9, 2022
sideshowbarker
commented
Mar 9, 2022
ddbeck
approved these changes
Mar 10, 2022
sideshowbarker
deleted the
sideshowbarker/History-pushstate-replacestate-unused-param-name-in-note
branch
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Related MDN change: mdn/content#13322 • Related spec bug: whatwg/html#6482
Relevant spec sections: