Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Adapt api.Window.onorientationchange to new events structure #15238

Merged
merged 2 commits into from
Mar 15, 2022
Merged

Adapt api.Window.onorientationchange to new events structure #15238

merged 2 commits into from
Mar 15, 2022

Conversation

queengooborg
Copy link
Collaborator

This PR adapts the orientationchange event of the Window API to conform to the new events structure.

@queengooborg
Adapt api.Window.onorientationchange to new events structure
bee6f2c 
This PR adapts the orientationchange event of the Window API to conform to the new events structure.
@queengooborg queengooborg added data:api 🐇 Compat data for Web APIs. https://developer.mozilla.org/docs/Web/API needs content update 📝 This PR needs a corresponding update to mdn/content to update the documentation labels Mar 2, 2022
@queengooborg queengooborg mentioned this pull request Mar 2, 2022
Closed
@queengooborg queengooborg removed the needs content update 📝 This PR needs a corresponding update to mdn/content to update the documentation label Mar 8, 2022
@queengooborg
Copy link
Collaborator Author

Removing the "needs content update" label because there's only an orientationchange_event page and no onorientationchange page, so content updates may occur independently.

@Elchi3
Copy link
Member

Elchi3 commented Mar 15, 2022

Conflict needs to be solved. Otherwise this looks good to me.

@Elchi3 Elchi3 merged commit 56d53f7 into mdn:main Mar 15, 2022
@queengooborg queengooborg deleted the api/Window/orientationchange/events branch March 15, 2022 13:54
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@Elchi3 Elchi3 Elchi3 approved these changes

Assignees
No one assigned
Labels
data:api 🐇 Compat data for Web APIs. https://developer.mozilla.org/docs/Web/API
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@queengooborg @Elchi3