Adapt api.ServiceWorkerRegistration.onupdatefound to new events structure #15549
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…ture This PR adapts the updatefound event of the ServiceWorkerRegistration API to conform to the new events structure.
queengooborg
added
data:api 🐇
foolip
approved these changes
Mar 30, 2022
| } | ||
| }, | ||
| "status": { | ||
| "experimental": true, |
There was a problem hiding this comment.
Looks like "experimental" is incorrectly set to true for lots of features in this file. Maybe worth a separate PR to fix?
Elchi3
approved these changes
Apr 1, 2022
There was a problem hiding this comment.
LGTM. Once mdn/content#14543 is merged, I'm happy to merge this one as well.
Elchi3
removed
the
needs content update 📝
|
I just merged the content PR, so I merge this one too. |
queengooborg
deleted the
api/ServiceWorkerRegistration/updatefound/events
branch
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR adapts the updatefound event of the ServiceWorkerRegistration API to conform to the new events structure.