-
Notifications
You must be signed in to change notification settings - Fork 2k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Correct data for Storage Access API #20094
Conversation
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM but like to hear what @chrisdavidmills thinks
See #20098 (comment) |
From #20098 (comment):
The |
I just tried running the following in the console while on MDN:
And it returned |
@queengooborg ahhhh, wait, I think I'm being stupid! I'm using Chrome Canary, which means that it is probably enabled fully by default rather than partially. Continue as you were ;-) |
Ah, that would do it, haha! How does this PR look then? Any changes needed? |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
In light of that realization. I'm approving. Nice one @queengooborg
This PR corrects the data for the Storage Access API for Chrome. This feature is reserved to Chrome's proprietary first-party sets and is not available to all websites, so it is marked as partial implementation.
Additionally, this removes the
version_removed
set on the flags. Not only were they incorrect (they were off by one), but the flag still enables the feature for websites not within first-party sets. (Although keeping the flag is technically against our irrelevant flag data policy, I feel that it is still worthwhile to retain as I personally don't consider gated access like first-party sets or origin trials to be "supported".)