Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Adds MAX_NUMBER_OF_DISABLED_STATIC_RULES #23533

Merged
merged 2 commits into from
Jul 8, 2024

Conversation

rebloor
Copy link
Collaborator

@rebloor rebloor commented Jun 27, 2024

Summary

Adds browser compatibility data for the declarativeNetRequest type MAX_NUMBER_OF_DISABLED_STATIC_RULES addressing the dev–doc-needed request from Bug 1896628[DNR] Enforce a limit to the maximum number of static rules disabled individually.

Version information for Chrome and Safari based on comments on Declarative Net Request proposal: disable individual static rules #162 and the Chrome documentation.

Related content change in PR TBC

@rebloor rebloor added the data:webext 🎲 Compat data for Browser Extensions. https://developer.mozilla.org/Add-ons/WebExtensions label Jun 27, 2024
@rebloor rebloor requested a review from dotproto June 27, 2024 09:31
@rebloor rebloor self-assigned this Jun 27, 2024
"__compat": {
"support": {
"chrome": {
"version_added": false
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Add note that although the constant is not exposed, that Chrome enforces a limit, AND that the limit is counted across all static rulesets instead of per ruleset.

The "not exposed' part is intentional for now, per w3c/webextensions#162 (comment)

@rebloor rebloor marked this pull request as ready for review July 8, 2024 02:50
@rebloor rebloor merged commit efc6d29 into mdn:main Jul 8, 2024
6 checks passed
@rebloor rebloor deleted the add-MAX_NUMBER_OF_DISABLED_STATIC_RULES branch July 8, 2024 02:52
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
data:webext 🎲 Compat data for Browser Extensions. https://developer.mozilla.org/Add-ons/WebExtensions
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants