Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Chromium and Safari don't support Worker in Shared Workers #24610

Merged
merged 5 commits into from
Oct 18, 2024

Conversation

skyclouds2001
Copy link
Contributor

@skyclouds2001 skyclouds2001 commented Oct 2, 2024

Summary

the Worker interface is not exposed to Shared Worker for chromium-based browsers, and likely will not be fixed recently, so it make sense to add notes to indicating it is not exposed to Shared Worker

Note: I'm not sure if partial_implementation or impl_url key should be added

see mdn/content#30880 (comment) and https://issues.chromium.org/issues/40695450, also https://github.com/chromium/chromium/blob/main/third_party/blink/renderer/core/workers/worker.idl

can be test using https://worker-playground.glitch.me/

Another note: BCD for Worker interface and properties/methods and Worker constructor for chrome is different, maybe a mistake?

Test results and supporting details

Related issues

@github-actions github-actions bot added the data:api 🐇 Compat data for Web APIs. https://developer.mozilla.org/docs/Web/API label Oct 2, 2024
@skyclouds2001 skyclouds2001 marked this pull request as ready for review October 2, 2024 19:34
api/Worker.json Outdated Show resolved Hide resolved
@skyclouds2001 skyclouds2001 changed the title Add notes for Worker indicating it is not exposed to Shared Worker Add notes for Worker indicating it is not exposed to Shared Worker in chromium Oct 3, 2024
@skyclouds2001 skyclouds2001 changed the title Add notes for Worker indicating it is not exposed to Shared Worker in chromium Chromium doesn't support Worker in Shared Workers Oct 9, 2024
@skyclouds2001 skyclouds2001 marked this pull request as draft October 10, 2024 16:53
@skyclouds2001 skyclouds2001 changed the title Chromium doesn't support Worker in Shared Workers Chromium and Safari doesn't support Worker in Shared Workers Oct 11, 2024
@skyclouds2001
Copy link
Contributor Author

researches


chromium

  • add support for dedicated worker

commit chromium/chromium@304237d
chrome feature entry https://chromestatus.com/feature/6080438103703552
issue https://issues.chromium.org/issues/40340498
code review https://chromium-review.googlesource.com/c/chromium/src/+/953746

local cli test

image


firefox

  • expose to dedicated worker & shared worker

commit mozilla/gecko-dev@8b59c15
issue https://bugzilla.mozilla.org/show_bug.cgi?id=1137398

  • expose to worker

commit mozilla/gecko-dev@12b78b9
issue https://bugzilla.mozilla.org/show_bug.cgi?id=1017988

note that service worker only supported via v44, so expose to worker is equal to expose to dedicated worker & shared worker between v34 to v39


safari

commit WebKit/WebKit@48880e3
issue https://bugs.webkit.org/show_bug.cgi?id=22723
browser release note https://developer.apple.com/documentation/safari-release-notes/safari-16_4-release-notes

image

@skyclouds2001 skyclouds2001 marked this pull request as ready for review October 11, 2024 01:05
Copy link
Contributor

@caugner caugner left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Overall LGTM, just one nit.

api/Worker.json Outdated Show resolved Hide resolved
@caugner caugner changed the title Chromium and Safari doesn't support Worker in Shared Workers Chromium and Safari don't support Worker in Shared Workers Oct 18, 2024
@caugner caugner merged commit 36d8926 into mdn:main Oct 18, 2024
6 checks passed
@skyclouds2001 skyclouds2001 deleted the worker branch October 18, 2024 20:34
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
data:api 🐇 Compat data for Web APIs. https://developer.mozilla.org/docs/Web/API
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants