Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Remove NavigatorGeolocation.json #5606

Merged
merged 2 commits into from
Jan 31, 2020
Merged

Remove NavigatorGeolocation.json #5606

merged 2 commits into from
Jan 31, 2020

Conversation

sideshowbarker
Copy link
Collaborator

w3c/geolocation#23 removed the Navigator* prefix from the NavigatorGeolocation interface. w3c/geolocation@26226b5

@sideshowbarker
Deprecate NavigatorGeolocation
9d43362 
w3c/geolocation#23 removed the Navigator*
prefix from the NavigatorGeolocation interface.

w3c/geolocation@26226b5
@ghost ghost added the data:api 🐇 Compat data for Web APIs. https://developer.mozilla.org/docs/Web/API label Jan 30, 2020
@queengooborg
Copy link
Collaborator

Hmm, if NavigatorGeolocation was renamed to Geolocation, then the more appropriate change would be to rename this file. However, it looks like we already have a file for the Geolocation API. They appear to have the same data as well -- as such, maybe we should nuke this whole file?

@sideshowbarker
Copy link
Collaborator Author

Hmm, if NavigatorGeolocation was renamed to Geolocation, then the more appropriate change would be to rename this file. However, it looks like we already have a file for the Geolocation API. They appear to have the same data as well -- as such, maybe we should nuke this whole file?

Yup, sounds right to me — I’ve pushed a follow-up that removes it

@queengooborg queengooborg changed the title Deprecate NavigatorGeolocation Remove NavigatorGeolocation.json Jan 31, 2020
queengooborg
queengooborg approved these changes Jan 31, 2020
View reviewed changes
Copy link
Collaborator

@queengooborg queengooborg left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks, looking good to me!

@queengooborg queengooborg merged commit 2cb1af2 into mdn:master Jan 31, 2020
@sideshowbarker sideshowbarker deleted the NavigatorGeolocation-deprecated branch January 31, 2020 07:58
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@queengooborg queengooborg queengooborg approved these changes

Assignees
No one assigned
Labels
data:api 🐇 Compat data for Web APIs. https://developer.mozilla.org/docs/Web/API
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@sideshowbarker @queengooborg