Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Make privacy an optional permission #5840

Merged
merged 1 commit into from
Mar 23, 2020
Merged

Make privacy an optional permission #5840

merged 1 commit into from
Mar 23, 2020

Conversation

rebloor
Copy link
Collaborator

@rebloor rebloor commented Mar 19, 2020

This change the privacy permission to the list of permissions that be can be requested optionally. Investigation suggested that this permission had always been optional in other browsers clearly.
For more details see 1618399 and the updated schema. Confirmation that this is optional in Chrome is provided in chrome.permissions in the section "Permissions that can not be specified as optional".

A checklist to help your pull request get merged faster:

  • Summarize your changes
  • Data: link to resources that verify support information (such as browser's docs, changelogs, source control, bug trackers, and tests)
  • Data: if you tested something, describe how you tested with details like browser and version
  • Review the results of the linter and fix problems reported (If you need help, please ask in a comment!)
  • Link to related issues or pull requests, if any

@rebloor rebloor requested a review from wbamberg March 19, 2020 09:51
@ghost ghost added the data:webext 🎲 Compat data for Browser Extensions. https://developer.mozilla.org/Add-ons/WebExtensions label Mar 19, 2020
Copy link
Collaborator

@wbamberg wbamberg left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks @rebloor !

@wbamberg wbamberg merged commit 1f50a8d into mdn:master Mar 23, 2020
@rebloor rebloor deleted the 1618399-make-privacy-an-optional-permission branch May 22, 2020 03:40
queengooborg added a commit to queengooborg/browser-compat-data that referenced this pull request Aug 10, 2024
… property

This PR updates and corrects version values for Chromium (Chrome, Opera, Samsung Internet, WebView Android) for the `optional_permissions` Web Extensions manifest property. This sets the feature(s) to a version range based upon the date that the feature was added to BCD with the intent of replacing `true` values with ranged values to eliminate `true` values from BCD.

Commit/PR Adding the Feature: mdn#1673, mdn#1771, mdn#5840, mdn#6112, mdn#12155
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
data:webext 🎲 Compat data for Browser Extensions. https://developer.mozilla.org/Add-ons/WebExtensions
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants