Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Remix ParentNode #9064

Merged
merged 7 commits into from
Feb 15, 2021
Merged

Remix ParentNode #9064

merged 7 commits into from
Feb 15, 2021

Conversation

Elchi3
Copy link
Member

@Elchi3 Elchi3 commented Feb 11, 2021

(Oh wow, what a mess.)

This PR takes apart the compat table at https://developer.mozilla.org/en-US/docs/Web/API/ParentNode#browser_compatibility and restructures things according to the new mixin data guideline.

Fun fact: In the past some folks suggested that documenting mixins instead of real APIs will lead to a lot of pages and that's why mixin pages are preferable. Well, all the pages happened anyway already!? All of the following pages exist in addition to the mixin page and so we had multiple data points (which this PR removes). Sigh.

https://developer.mozilla.org/en-US/docs/Web/API/Document/querySelector
https://developer.mozilla.org/en-US/docs/Web/API/DocumentFragment/querySelector
https://developer.mozilla.org/en-US/docs/Web/API/Element/querySelector
https://developer.mozilla.org/en-US/docs/Web/API/Document/querySelectorAll
https://developer.mozilla.org/en-US/docs/Web/API/DocumentFragment/querySelectorAll
https://developer.mozilla.org/en-US/docs/Web/API/Element/querySelectorAll

@github-actions github-actions bot added the data:api 🐇 Compat data for Web APIs. https://developer.mozilla.org/docs/Web/API label Feb 11, 2021
Copy link
Collaborator

@foolip foolip left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I can check this against the collector too, but don't block on that if you want to merge.

api/DocumentFragment.json Show resolved Hide resolved
Copy link
Collaborator

@foolip foolip left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I've applied suggestions for everything the collector produced diffs for and then some. Hope it's clear what's from the collector and what's a safe guess, I've commented at least once for each but not attributed every single change to a source.

Since I've done this manually in the review UI, errors are still possible, please check for reasonableness.

api/_mixins/ParentNode__Document.json Outdated Show resolved Hide resolved
api/_mixins/ParentNode__Document.json Outdated Show resolved Hide resolved
api/_mixins/ParentNode__Document.json Outdated Show resolved Hide resolved
api/_mixins/ParentNode__Document.json Outdated Show resolved Hide resolved
api/_mixins/ParentNode__Document.json Outdated Show resolved Hide resolved
api/_mixins/ParentNode__DocumentFragment.json Outdated Show resolved Hide resolved
api/_mixins/ParentNode__DocumentFragment.json Outdated Show resolved Hide resolved
api/_mixins/ParentNode__DocumentFragment.json Outdated Show resolved Hide resolved
api/_mixins/ParentNode__DocumentFragment.json Outdated Show resolved Hide resolved
api/_mixins/ParentNode__DocumentFragment.json Outdated Show resolved Hide resolved
@Elchi3
Copy link
Member Author

Elchi3 commented Feb 15, 2021

Thanks, very useful to have this all in now! Firefox Android 78 doesn't exist, so it is bumped to 79. Otherwise it all made sense to me.

Copy link
Collaborator

@foolip foolip left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Argh, I discovered a lot more on a second look.

api/_mixins/ParentNode__Document.json Outdated Show resolved Hide resolved
api/_mixins/ParentNode__Document.json Outdated Show resolved Hide resolved
api/_mixins/ParentNode__DocumentFragment.json Outdated Show resolved Hide resolved
api/_mixins/ParentNode__DocumentFragment.json Outdated Show resolved Hide resolved
api/_mixins/ParentNode__Element.json Show resolved Hide resolved
api/_mixins/ParentNode__DocumentFragment.json Outdated Show resolved Hide resolved
api/_mixins/ParentNode__DocumentFragment.json Show resolved Hide resolved
api/_mixins/ParentNode__Element.json Show resolved Hide resolved
api/_mixins/ParentNode__DocumentFragment.json Outdated Show resolved Hide resolved
api/_mixins/ParentNode__DocumentFragment.json Outdated Show resolved Hide resolved
@Elchi3
Copy link
Member Author

Elchi3 commented Feb 15, 2021

Thanks for the detailed second look!

api/_mixins/ParentNode__Document.json Outdated Show resolved Hide resolved
api/_mixins/ParentNode__Element.json Show resolved Hide resolved
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
data:api 🐇 Compat data for Web APIs. https://developer.mozilla.org/docs/Web/API
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants