Demix NonDocumentTypeChildNode #9065
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
github-actions
bot
added
the
data:api 🐇
foolip
approved these changes
Feb 13, 2021
foolip
reviewed
Feb 13, 2021
Co-authored-by: Philip Jägenstedt <[email protected]>
|
Interesting! Thanks for your research, Philip! Having this split up is so good. Can't wait to make this more clear on MDN, too. |
foolip
approved these changes
Feb 14, 2021
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
NonDocumentTypeChildNode, read that again, NonDocumentTypeChildNode ...
So, what do you think it does? If you break it down, it is relatively simple: It adds two methods to Element and CharacterData. (why don't just say so, right?)
When documenting this as a mixin instead, you get this:
https://developer.mozilla.org/en-US/docs/Web/API/NonDocumentTypeChildNode
This PR re-arranges this piece of obscure art and I will definitely delete/re-write the MDN pages soon.