Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add Permissions Policy (aka Feature Policy) spec URLs #9586

Merged
merged 1 commit into from
Mar 25, 2021

Conversation

sideshowbarker
Copy link
Collaborator

No description provided.

@github-actions github-actions bot added the data:http 🚠 Compat data for HTTP features. https://developer.mozilla.org/docs/Web/HTTP label Mar 24, 2021
Base automatically changed from master to main March 24, 2021 12:54
Copy link
Member

@Elchi3 Elchi3 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Hm, should we wait here given the renaming?

@sideshowbarker sideshowbarker force-pushed the sideshowbarker/feature-policy-spec-urls-add branch from 5cac0e7 to 4f111f7 Compare March 24, 2021 17:42
@sideshowbarker sideshowbarker force-pushed the sideshowbarker/feature-policy-spec-urls-add branch from 4f111f7 to 892a0ca Compare March 24, 2021 17:51
@sideshowbarker
Copy link
Collaborator Author

Hm, should we wait here given the renaming?

I thought about that too — but it seems there’s no need to wait for the renaming, because the spec_url values aren’t going to change as a result of the renaming. That is, when we rename the BCD filenames and the MDN article titles, they’re still going be referencing the same spec URLs.

To be clear: The spec URLs in this patch all already point to the right sections in the relevant specs — and those spec sections have, with one exception, already been retitled to reference the Permissions Policy spec rather than Feature Policy.

So all the spec_url values in this patch already have some form of #permissions-policy anchors — with the one exception being https://w3c.github.io/accelerometer/#accelerometer-interface, because that spec has no Permissions Policy Integration section yet. So I raised w3c/accelerometer#60 to add a Permissions Policy Integration section for that.

But I don’t think we need to block this PR on that PR getting merged first. Instead, after that PR gets merged, we can do a follow-up here to update our spec_url for it.

Copy link
Member

@Elchi3 Elchi3 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Well okay, can't hurt to merge this I guess. Thanks for digging into this!

@Elchi3 Elchi3 merged commit 252e39f into mdn:main Mar 25, 2021
@sideshowbarker sideshowbarker deleted the sideshowbarker/feature-policy-spec-urls-add branch March 25, 2021 09:39
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
data:http 🚠 Compat data for HTTP features. https://developer.mozilla.org/docs/Web/HTTP
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants