Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Hidden paragraph BCD data still exists in content and in code #2228

Closed
peterbe opened this issue Feb 9, 2021 · 11 comments · Fixed by #5330 or #5341
Closed

Hidden paragraph BCD data still exists in content and in code #2228

peterbe opened this issue Feb 9, 2021 · 11 comments · Fixed by #5330 or #5341

Comments

@peterbe
Copy link
Contributor

peterbe commented Feb 9, 2021

In mdn/yari#1191 we made the text:

<div class="hidden">The compatibility table on this page is generated from structured data. If you'd like to contribute to the data, please check out <a href="https://github.com/mdn/browser-compat-data">https://github.com/mdn/browser-compat-data</a> and send us a pull request.</div>

be something that's part of the <BrowserCompatibilityTable> component. So every appearance of it in the content is redundant. This issue is about cleaning this up from the content.

@peterbe
Copy link
Contributor Author

peterbe commented Feb 9, 2021

@nschonni Let's tackle this one once we've taken care of all the excess class="external" on all external links.

@peterbe
Copy link
Contributor Author

peterbe commented Feb 9, 2021

It's clearly still there a lot:

MOZILLA/MDN/content  main ✔
▶ rg 'The compatibility table' | wc -l
    1247

@teoli2003
Copy link
Contributor

teoli2003 commented May 26, 2021

I think this has to stay open until all are removed. I think it is my fault if it has been closed as I linked PR #5330 to it, even if it is a partial fix.

@peterbe peterbe reopened this May 26, 2021
@peterbe
Copy link
Contributor Author

peterbe commented May 26, 2021

Clearly some have been removed compared to by Feb 9 comment above:

▶ rg 'The compatibility table' | wc -l
    1222

@peterbe
Copy link
Contributor Author

peterbe commented May 26, 2021

Bha! What's going on. I didn't mean for this to be closed. Sorry.

@peterbe peterbe reopened this May 26, 2021
@teoli2003
Copy link
Contributor

Clearly some have been removed compared to by Feb 9 comment above:

▶ rg 'The compatibility table' | wc -l
    1222

I noticed that it was near 1400 yesterday, meaning it was climbing. That's why I started removing them.

I guess people are cloning pages than modifying them.

@teoli2003
Copy link
Contributor

We have removed the hidden paragraph BCD data from mdn/content.
rg 'The compatibility table' | wc -l 2

This 2 are not from such paragraph but from the contribute area explaining how to put compatibility tables in page.

@peterbe Is there still something to do here, or can we close this issue?

@peterbe
Copy link
Contributor Author

peterbe commented May 27, 2021

There might be some manual searching where it has minor spelling differences that the python script can't pick up.
Otherwise, the next thing to do is to re-apply that Python script on mdn/translated-content :)

@teoli2003
Copy link
Contributor

I ran the script with different needles, and manually fixed the remaining issues. :-), so I'm fairly confident for mdn/content.

I'm a bit afraid to look at the size of mdn/translated-content :-)

@peterbe
Copy link
Contributor Author

peterbe commented May 28, 2021

Let's now redirect to mdn/translated-content#1008

@Rumyra Rumyra added needs triage Triage needed by staff and/or partners. Automatically applied when an issue is opened. enhancement and removed needs triage Triage needed by staff and/or partners. Automatically applied when an issue is opened. labels Jun 7, 2021
@sideshowbarker
Copy link
Collaborator

I’m closing this here because per #2228 (comment) it seems to be resolved for the mdn/content repo — and because the follow-up issue for that mdn/translated-content repo has been raised at mdn/translated-content#1008.

But if I’m mistaken and this should in fact remain open, then somebody please do go ahead and re-open it.

@github-actions github-actions bot locked as resolved and limited conversation to collaborators Aug 1, 2022
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
None yet
Projects
None yet
4 participants