Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

MouseEvent - remove experimental on features and tidy #10220

Merged
merged 2 commits into from
Nov 5, 2021

Conversation

hamishwillee
Copy link
Collaborator

Fixes #10120

MouseEvent.offsetX and offsetY were marked as experimental. As per mdn/browser-compat-data#13206 they are not. This removes the markup.

A bunch of other cases were marked experimental too. This removes those as appropriate, also fixes up syntax sections and general layout changes for all properties. There were some cases where docs said "refer to browser compat for more information" where said information is not provided - so I removed those comments too.

@hamishwillee hamishwillee requested a review from a team as a code owner November 2, 2021 01:03
@hamishwillee hamishwillee requested review from Elchi3 and removed request for a team November 2, 2021 01:03
@github-actions github-actions bot added the Content:WebAPI Web API docs label Nov 2, 2021
@github-actions
Copy link
Contributor

github-actions bot commented Nov 2, 2021

Preview URLs

Flaws

Note! 21 documents with no flaws that don't need to be listed. 🎉

URL: /en-US/docs/Web/API/UIEvent/which
Title: UIEvent.which
on GitHub
Flaw count: 2

  • heading_links:
    • h3 heading contains an <a> tag
    • h3 heading contains an <a> tag

URL: /en-US/docs/Web/API/MouseEvent
Title: MouseEvent
on GitHub
Flaw count: 2

  • macros:
    • /en-US/docs/Web/API/MouseEvent/which redirects to /en-US/docs/Web/API/UIEvent/which
    • /en-US/docs/Web/API/MouseEvent/mozPressure does not exist

URL: /en-US/docs/Web/API/MouseEvent/region
Title: MouseEvent.region
on GitHub
Flaw count: 2

  • macros:
    • /en-US/docs/Web/API/CanvasRenderingContext2D/addHitRegion does not exist
  • broken_links:
    • Can't resolve /en-US/docs/Web/API/CanvasRenderingContext2D/addHitRegion

External URLs

URL: /en-US/docs/Web/API/UIEvent/which
Title: UIEvent.which
on GitHub

No new external URLs


URL: /en-US/docs/Web/API/MouseEvent
Title: MouseEvent
on GitHub

No new external URLs


URL: /en-US/docs/Web/API/MouseEvent/pageY
Title: MouseEvent.pageY
on GitHub

No new external URLs


URL: /en-US/docs/Web/API/MouseEvent/clientX
Title: MouseEvent.clientX
on GitHub

No new external URLs


URL: /en-US/docs/Web/API/MouseEvent/metaKey
Title: MouseEvent.metaKey
on GitHub

No new external URLs


URL: /en-US/docs/Web/API/MouseEvent/pageX
Title: MouseEvent.pageX
on GitHub

No new external URLs


URL: /en-US/docs/Web/API/MouseEvent/x
Title: MouseEvent.x
on GitHub

No new external URLs


URL: /en-US/docs/Web/API/MouseEvent/offsetX
Title: MouseEvent.offsetX
on GitHub

No new external URLs


URL: /en-US/docs/Web/API/MouseEvent/mozInputSource
Title: MouseEvent.mozInputSource
on GitHub

No new external URLs


URL: /en-US/docs/Web/API/MouseEvent/shiftKey
Title: MouseEvent.shiftKey
on GitHub

No new external URLs


URL: /en-US/docs/Web/API/MouseEvent/buttons
Title: MouseEvent.buttons
on GitHub

No new external URLs


URL: /en-US/docs/Web/API/MouseEvent/offsetY
Title: MouseEvent.offsetY
on GitHub

No new external URLs


URL: /en-US/docs/Web/API/MouseEvent/altKey
Title: MouseEvent.altKey
on GitHub

No new external URLs


URL: /en-US/docs/Web/API/MouseEvent/relatedTarget
Title: MouseEvent.relatedTarget
on GitHub

No new external URLs


URL: /en-US/docs/Web/API/MouseEvent/movementY
Title: MouseEvent.movementY
on GitHub

No new external URLs


URL: /en-US/docs/Web/API/MouseEvent/clientY
Title: MouseEvent.clientY
on GitHub

No new external URLs


URL: /en-US/docs/Web/API/MouseEvent/y
Title: MouseEvent.y
on GitHub

No new external URLs


URL: /en-US/docs/Web/API/MouseEvent/getModifierState
Title: MouseEvent.getModifierState()
on GitHub

No new external URLs


URL: /en-US/docs/Web/API/MouseEvent/screenY
Title: MouseEvent.screenY
on GitHub

No new external URLs


URL: /en-US/docs/Web/API/MouseEvent/screenX
Title: MouseEvent.screenX
on GitHub

No new external URLs


URL: /en-US/docs/Web/API/MouseEvent/ctrlKey
Title: MouseEvent.ctrlKey
on GitHub

No new external URLs


URL: /en-US/docs/Web/API/MouseEvent/button
Title: MouseEvent.button
on GitHub

No new external URLs


URL: /en-US/docs/Web/API/MouseEvent/movementX
Title: MouseEvent.movementX
on GitHub

No new external URLs


URL: /en-US/docs/Web/API/MouseEvent/region
Title: MouseEvent.region
on GitHub

No new external URLs

(this comment was updated 2021-11-04 23:17:28.125601)

Copy link
Contributor

@teoli2003 teoli2003 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Two sentences to remove, I believe. Else this is a nice clean-up! Thanks.

files/en-us/web/api/mouseevent/clientx/index.md Outdated Show resolved Hide resolved
files/en-us/web/api/mouseevent/clienty/index.md Outdated Show resolved Hide resolved
@teoli2003 teoli2003 merged commit d40315b into mdn:main Nov 5, 2021
@github-actions github-actions bot locked as resolved and limited conversation to collaborators Nov 5, 2022
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
Content:WebAPI Web API docs
Projects
None yet
Development

Successfully merging this pull request may close these issues.

MouseEvent.offset{X,Y}: not actually experimental
2 participants