Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

ondragleave: Update and convert static code example to live example #12001

Merged
merged 1 commit into from
Jan 18, 2022
Merged

ondragleave: Update and convert static code example to live example #12001

merged 1 commit into from
Jan 18, 2022

Conversation

AnilSeervi
Copy link
Contributor

Summary

Convert static ondragleave code example to a live example

Motivation

Open-source

Supporting details

Related issues

Related to #11364

Metadata

  • Adds a new document
  • Rewrites (or significantly expands) a document
  • Fixes a typo, bug, or other error

@AnilSeervi AnilSeervi requested a review from a team as a code owner January 14, 2022 05:29
@AnilSeervi AnilSeervi requested review from Elchi3 and removed request for a team January 14, 2022 05:29
@github-actions github-actions bot added the Content:WebAPI Web API docs label Jan 14, 2022
@github-actions
Copy link
Contributor

Preview URLs

Flaws

None! 🎉

External URLs

URL: /en-US/docs/Web/API/GlobalEventHandlers/ondragleave
Title: GlobalEventHandlers.ondragleave
on GitHub

No new external URLs

AnilSeervi
AnilSeervi commented Jan 14, 2022
View reviewed changes
Copy link
Contributor Author

@AnilSeervi AnilSeervi left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

As these are going to end up on new-style event pages, it makes sense to use addEventListener rather than the global event handler(ondragleave)?
#11365 (review)

@Elchi3
Copy link
Member

Elchi3 commented Jan 18, 2022

As these are going to end up on new-style event pages, it makes sense to use addEventListener rather than the global event handler(ondragleave)?
#11365 (review)

Yes, probably better to use addEventListener then. However, these pages haven't been moved yet and I think we should land this for now and then update once we actually make it a new-style event page.

Elchi3
Elchi3 approved these changes Jan 18, 2022
View reviewed changes
Copy link
Member

@Elchi3 Elchi3 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good and live example works nicely for me 👍

@Elchi3 Elchi3 merged commit db76fe9 into mdn:main Jan 18, 2022
@github-actions github-actions bot locked as resolved and limited conversation to collaborators Jan 18, 2023
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Reviewers

@Elchi3 Elchi3 Elchi3 approved these changes

Assignees
No one assigned
Labels
Content:WebAPI Web API docs
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@AnilSeervi @Elchi3