Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Adapt ServiceWorkerContainer API to new events structure #13924

Merged
merged 3 commits into from
Mar 24, 2022
Merged

Adapt ServiceWorkerContainer API to new events structure #13924

merged 3 commits into from
Mar 24, 2022

Conversation

queengooborg
Copy link
Collaborator

This PR adapts the ServiceWorkerContainer API to conform to the new events structure.

BCD PR: mdn/browser-compat-data#15200

This PR adapts the ServiceWorkerContainer API to conform to the new events structure.
@queengooborg queengooborg requested review from a team as code owners March 16, 2022 01:29
@queengooborg queengooborg requested review from wbamberg and removed request for a team March 16, 2022 01:29
@github-actions github-actions bot added the Content:WebAPI Web API docs label Mar 16, 2022
@github-actions
Copy link
Contributor

github-actions bot commented Mar 16, 2022

Preview URLs

Flaws

Note! 1 document with no flaws that don't need to be listed. 🎉

URL: /en-US/docs/Web/API/ServiceWorkerContainer
Title: ServiceWorkerContainer
on GitHub
Flaw count: 3

  • bad_bcd_links:
    • no explanation!
    • no explanation!
    • no explanation!

URL: /en-US/docs/Web/API/ServiceWorkerContainer/controllerchange_event
Title: ServiceWorkerContainer: controllerchange event
on GitHub
Flaw count: 1

  • bad_bcd_queries:
    • No BCD data for query: api.ServiceWorkerContainer.controllerchange_event

URL: /en-US/docs/Web/API/ServiceWorkerContainer/message_event
Title: ServiceWorkerContainer: message event
on GitHub
Flaw count: 1

  • macros:
    • /en-US/docs/Web/API/WindowProxy does not exist

URL: /en-US/docs/Web/API/ServiceWorkerContainer/error_event
Title: ServiceWorkerContainer: error event
on GitHub
Flaw count: 1

  • bad_bcd_queries:
    • No BCD data for query: api.ServiceWorkerContainer.error_event

External URLs

URL: /en-US/docs/Web/API/ServiceWorkerContainer
Title: ServiceWorkerContainer
on GitHub

No new external URLs


URL: /en-US/docs/Web/API/ServiceWorkerContainer/controllerchange_event
Title: ServiceWorkerContainer: controllerchange event
on GitHub

No new external URLs


URL: /en-US/docs/Web/API/ServiceWorkerContainer/startMessages
Title: ServiceWorkerContainer.startMessages()
on GitHub

No new external URLs


URL: /en-US/docs/Web/API/ServiceWorkerContainer/message_event
Title: ServiceWorkerContainer: message event
on GitHub

No new external URLs


URL: /en-US/docs/Web/API/ServiceWorkerContainer/error_event
Title: ServiceWorkerContainer: error event
on GitHub

No new external URLs

(this comment was updated 2022-03-24 02:21:57.323482)

@@ -9077,6 +9077,9 @@
/en-US/docs/Web/API/ServiceWorkerContainer.controller /en-US/docs/Web/API/ServiceWorkerContainer/controller
/en-US/docs/Web/API/ServiceWorkerContainer.getRegistration([scope]) /en-US/docs/Web/API/ServiceWorkerContainer/getRegistration
/en-US/docs/Web/API/ServiceWorkerContainer.register /en-US/docs/Web/API/ServiceWorkerContainer/register
/en-US/docs/Web/API/ServiceWorkerContainer/oncontrollerchange /en-US/docs/Web/API/ServiceWorkerContainer
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This is strange. It looks like oncontrollerchange is removed and redirected to ServiceWorkerContainer? It should have been moved to controllerchange_event.

@Elchi3
Copy link
Member

Elchi3 commented Mar 23, 2022

Changing the redirect file isn't the trick here :)

I think there is a mistake where you deleted the Web/API/ServiceWorkerContainer/oncontrollerchange page instead of yarn move'ing it to Web/API/ServiceWorkerContainer/controllerchange_event

@queengooborg
Copy link
Collaborator Author

Ahh, that's what's been going on! Yeah, I probably ran delete instead on accident... 😅

@Elchi3 Elchi3 merged commit d12a8bd into mdn:main Mar 24, 2022
@queengooborg queengooborg deleted the api/ServiceWorkerContainer/events branch March 24, 2022 18:04
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Content:WebAPI Web API docs
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants