-
Notifications
You must be signed in to change notification settings - Fork 22.5k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Fix issue 15872: remove live sample inclusions in CSS #16013
Conversation
Just a question. You have used different flavors of height arguments in the macros:
They all work, but what is the preferred way to provide height? As per https://developer.mozilla.org/en-US/docs/MDN/Structures/Live_samples#live_sample_macros
Shouldn't we be providing widths here? Is the width requirement for mobile screens? In which case |
I don't know. Usually I prefer to omit "px" but not sure it matters.
Yes, we should probably update the meta-docs :). See also mdn/yari#5016. |
According to mdn/yari#5016 (comment) it looks like we ought to omit "px", although I think it works either way. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
So, these things were transclusions of themselves (I don't want to see yari's code to handle this parameter)
Good find! Looks like we need to update the doc https://developer.mozilla.org/en-US/docs/MDN/Structures/Live_samples#live_sample_macros to remove |
Yes, please. |
* Fix :-moz-list-bullet * Fix @counter-style/pad * Fix @counter-style/negative * Fix font-variant-ligatures * Fix flex-wrap * Fix font-variant * Fix z-index * Fix font-variant-alternates * Fix box-orient * Fix flex-grow * Fix font-language-override * Make div4 a little taller * Omit px for iframe height
Part of #15872 : this removes the transclusion parameter from all
EmbedLiveSample
calls in the CSS docs.