Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Pendantic: basic v. simple selector #17324

Merged
merged 1 commit into from
Jun 16, 2022
Merged

Pendantic: basic v. simple selector #17324

merged 1 commit into from
Jun 16, 2022

Conversation

estelle
Copy link
Member

@estelle estelle commented Jun 16, 2022

We have been using the term simple and complex selector incorrectly. A simple selector is one that uses only one component, like a or :nth-of-type(3n+2). A complex selector is selector that has a combinator, including just a space, such as ul li. A compound selector is one that has multiple components without a space, such as div#myId.myClass.

I am not sure if we want to clarify and be pedantic, but the term we've been using are not fully accurate.

Summary

Motivation

Supporting details

Related issues

Metadata

  • Adds a new document
  • Rewrites (or significantly expands) a document
  • Fixes a typo, bug, or other error

@estelle estelle requested review from a team as code owners June 16, 2022 00:46
@estelle estelle requested review from sideshowbarker and dipikabh and removed request for a team June 16, 2022 00:46
@github-actions github-actions bot added Content:CSS Cascading Style Sheets docs Content:WebAPI Web API docs labels Jun 16, 2022
@estelle
Copy link
Member Author

estelle commented Jun 16, 2022

I also slipped a removal of matches() since all browsers support is() and where() now.

@github-actions
Copy link
Contributor

Preview URLs

Flaws

Note! 4 documents with no flaws that don't need to be listed. 🎉

URL: /en-US/docs/Web/CSS/:is
Title: :is() (:matches(), :any())
on GitHub
Flaw count: 1

  • macros:
    • /en-US/docs/Web/HTML/Element/h1 redirects to /en-US/docs/Web/HTML/Element/Heading_Elements

URL: /en-US/docs/Web/CSS/Reference
Title: CSS reference
on GitHub
Flaw count: 1

  • macros:
    • wrong xref macro used (consider changing which macro you use)

External URLs

URL: /en-US/docs/Web/CSS/:is
Title: :is() (:matches(), :any())
on GitHub


URL: /en-US/docs/Web/CSS/:first-of-type
Title: :first-of-type
on GitHub

No new external URLs


URL: /en-US/docs/Web/CSS/Specificity
Title: Specificity
on GitHub

No new external URLs


URL: /en-US/docs/Web/CSS/Layout_cookbook/Breadcrumb_Navigation
Title: Breadcrumb Navigation
on GitHub

No new external URLs


URL: /en-US/docs/Web/CSS/Reference
Title: CSS reference
on GitHub

No new external URLs


URL: /en-US/docs/Web/API/Document/querySelector
Title: Document.querySelector()
on GitHub

No new external URLs

Copy link
Contributor

@teoli2003 teoli2003 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I think we should be precise on our side (simple, complex, compound).

This doesn't mean being pedantic, that is, it doesn't mean we shouldn't explain at great lengths the difference between the three words. Maybe a mention like you explained here in the glossary.

@teoli2003 teoli2003 merged commit a8bc68c into mdn:main Jun 16, 2022
@hamishwillee
Copy link
Collaborator

This doesn't mean being pedantic, that is, it doesn't mean we shouldn't explain at great lengths the difference between the three words. Maybe a mention like you explained here in the glossary.

I agree. If there is a proper definition we shouldn't make up our own. Creating a glossary and linking to it may help us get smarter at spotting the misuse in future.

@estelle estelle deleted the complex branch July 19, 2022 22:15
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Content:CSS Cascading Style Sheets docs Content:WebAPI Web API docs
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants