Adjusting description #17522
Merged
Adjusting description #17522
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
The use of "semantic" is [creating confusion](w3c/aria-practices#353 (comment)) on what this element actually does. While in here I tweaked the overall description.
Preview URLsFlawsNone! 🎉 External URLsURL: No new external URLs (this comment was updated 2022-06-22 16:20:11.808526) |
Because the example pulls in both blocks of code.
scottaohara
requested changes
Jun 21, 2022
In deference to Scott's point that the spec uses the word.
scottaohara
approved these changes
Jun 22, 2022
schalkneethling
approved these changes
Jun 22, 2022
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Summary
Removed use of "semantic", tweaked description, linked
<menuitem>for broader context.Motivation
The use of "semantic" is creating confusion on what this element actually does. While in here I tweaked the overall description.
Supporting details
Links to other sources in this comment: w3c/aria-practices#353 (comment)
Metadata