-
Notifications
You must be signed in to change notification settings - Fork 22.5k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Correct usage of ellipsis, part 2 #18171
Merged
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
OnkarRuikar
requested review from
jpmedley,
Josh-Cena,
schalkneethling,
estelle and
Rumyra
and removed request for
a team
July 10, 2022 06:54
github-actions
bot
added
Content:CSS
Cascading Style Sheets docs
Content:HTML
Hypertext Markup Language docs
Content:JS
JavaScript docs
Content:Learn
Learning area docs
Content:MathML
MathML docs
Content:Media
Media docs
Content:SVG
SVG docs
Content:wasm
WebAssembly docs
Content:WebAPI
Web API docs
labels
Jul 10, 2022
This comment was marked as resolved.
This comment was marked as resolved.
@teoli2003, @Josh-Cena regarding moving to prettier. There are some cases in code like: function foo() {
const a = 1;
...
} Should we convert them to function foo() {
const a = 1;
// ...
} so it'll not choke the eslint/prettier? |
Absolutely 👍 |
teoli2003
suggested changes
Jul 10, 2022
files/en-us/web/javascript/reference/functions/rest_parameters/index.md
Outdated
Show resolved
Hide resolved
teoli2003
approved these changes
Jul 10, 2022
This was referenced Jul 11, 2022
This was referenced Jul 19, 2022
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Labels
Content:CSS
Cascading Style Sheets docs
Content:HTML
Hypertext Markup Language docs
Content:JS
JavaScript docs
Content:Learn
Learning area docs
Content:MathML
MathML docs
Content:Media
Media docs
Content:SVG
SVG docs
Content:wasm
WebAssembly docs
Content:WebAPI
Web API docs
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Adding to #18170.