Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Comment out ellipsis in code blocks, part 3 #18295

Merged
merged 3 commits into from
Jul 13, 2022
Merged

Comment out ellipsis in code blocks, part 3 #18295

merged 3 commits into from
Jul 13, 2022

Conversation

OnkarRuikar
Copy link
Contributor

Adding to #18206.

Ellipsis in markdown code blocks are syntax errors.
In order to have smooth transition to Prettier and ESLint the PR comments out such bare ellipses.

@OnkarRuikar OnkarRuikar requested review from a team as code owners July 13, 2022 02:00
@OnkarRuikar OnkarRuikar requested review from teoli2003 and removed request for a team July 13, 2022 02:00
@github-actions github-actions bot added the Content:Learn Learning area docs label Jul 13, 2022
@github-actions
Copy link
Contributor

github-actions bot commented Jul 13, 2022 •
edited
Loading

Preview URLs

Flaws

Note! 16 documents with no flaws that don't need to be listed. 🎉

URL: /en-US/docs/Learn/Server-side/Express_Nodejs/development_environment
Title: Setting up a Node development environment
on GitHub
Flaw count: 1

  • broken_links:
    • Link points to the page it's already on

URL: /en-US/docs/Learn/Server-side/Express_Nodejs/forms
Title: Express Tutorial Part 6: Working with forms
on GitHub
Flaw count: 1

  • broken_links:
    • Link points to the page it's already on

URL: /en-US/docs/Learn/Server-side/Express_Nodejs/routes
Title: Express Tutorial Part 4: Routes and controllers
on GitHub
Flaw count: 1

  • broken_links:
    • Link points to the page it's already on

URL: /en-US/docs/Learn/Server-side/Express_Nodejs/Introduction
Title: Express/Node introduction
on GitHub
Flaw count: 1

  • broken_links:
    • Link points to the page it's already on

URL: /en-US/docs/Learn/Server-side/First_steps/Web_frameworks
Title: Server-side web frameworks
on GitHub
Flaw count: 1

  • broken_links:
    • Link points to the page it's already on

URL: /en-US/docs/Learn/JavaScript/Objects/Object_prototypes
Title: Object prototypes
on GitHub
Flaw count: 1

  • macros:
    • /en-US/docs/Web/JavaScript/Reference/Global_Objects/Object/__proto__ redirects to /en-US/docs/Web/JavaScript/Reference/Global_Objects/Object/proto

URL: /en-US/docs/Learn/JavaScript/First_steps/What_is_JavaScript
Title: What is JavaScript?
on GitHub
Flaw count: 1

  • broken_links:
    • Link points to the page it's already on

URL: /en-US/docs/Learn/JavaScript/First_steps/What_went_wrong
Title: What went wrong? Troubleshooting JavaScript
on GitHub
Flaw count: 1

  • broken_links:
    • Link points to the page it's already on

URL: /en-US/docs/Learn/JavaScript/First_steps/Strings
Title: Handling text — strings in JavaScript
on GitHub
Flaw count: 1

  • broken_links:
    • Link points to the page it's already on

URL: /en-US/docs/Learn/JavaScript/First_steps/Useful_string_methods
Title: Useful string methods
on GitHub
Flaw count: 1

  • broken_links:
    • Link points to the page it's already on

URL: /en-US/docs/Learn/Tools_and_testing/Client-side_JavaScript_frameworks/Ember_interactivity_events_state
Title: Ember interactivity: Events, classes and state
on GitHub
Flaw count: 2

  • broken_links:
    • Can't resolve /en-US/docs/Web/API/Document/keydown_event
    • Link points to the page it's already on

URL: /en-US/docs/Learn/Tools_and_testing/Client-side_JavaScript_frameworks/Main_features
Title: Framework main features
on GitHub
Flaw count: 1

  • broken_links:
    • Link points to the page it's already on

External URLs

URL: /en-US/docs/Learn/Server-side/Express_Nodejs/development_environment
Title: Setting up a Node development environment
on GitHub

No new external URLs

URL: /en-US/docs/Learn/Server-side/Express_Nodejs/deployment
Title: Express Tutorial Part 7: Deploying to production
on GitHub

No new external URLs

URL: /en-US/docs/Learn/Server-side/Express_Nodejs/forms
Title: Express Tutorial Part 6: Working with forms
on GitHub

No new external URLs

URL: /en-US/docs/Learn/Server-side/Express_Nodejs/forms/Create_genre_form
Title: Create genre form
on GitHub

No new external URLs

URL: /en-US/docs/Learn/Server-side/Express_Nodejs/Displaying_data/Genre_detail_page
Title: Genre detail page
on GitHub

No new external URLs

URL: /en-US/docs/Learn/Server-side/Express_Nodejs/Displaying_data/flow_control_using_async
Title: Asynchronous flow control using async
on GitHub

No new external URLs

URL: /en-US/docs/Learn/Server-side/Express_Nodejs/Displaying_data/Home_page
Title: Home page
on GitHub

No new external URLs

URL: /en-US/docs/Learn/Server-side/Express_Nodejs/skeleton_website
Title: Express Tutorial Part 2: Creating a skeleton website
on GitHub

No new external URLs

URL: /en-US/docs/Learn/Server-side/Express_Nodejs/routes
Title: Express Tutorial Part 4: Routes and controllers
on GitHub

No new external URLs

URL: /en-US/docs/Learn/Server-side/Express_Nodejs/Introduction
Title: Express/Node introduction
on GitHub

No new external URLs

URL: /en-US/docs/Learn/Server-side/Django/Forms
Title: Django Tutorial Part 9: Working with forms
on GitHub

No new external URLs

URL: /en-US/docs/Learn/Server-side/Django/Sessions
Title: Django Tutorial Part 7: Sessions framework
on GitHub

No new external URLs

URL: /en-US/docs/Learn/Server-side/Django/Testing
Title: Django Tutorial Part 10: Testing a Django web application
on GitHub

URL: /en-US/docs/Learn/Server-side/Django/Authentication
Title: Django Tutorial Part 8: User authentication and permissions
on GitHub

No new external URLs

URL: /en-US/docs/Learn/Server-side/First_steps/Client-Server_overview
Title: Client-Server Overview
on GitHub

No new external URLs

URL: /en-US/docs/Learn/Server-side/First_steps/Web_frameworks
Title: Server-side web frameworks
on GitHub

No new external URLs

URL: /en-US/docs/Learn/JavaScript/Client-side_web_APIs/Drawing_graphics
Title: Drawing graphics
on GitHub

No new external URLs

URL: /en-US/docs/Learn/JavaScript/Client-side_web_APIs/Client-side_storage
Title: Client-side storage
on GitHub

No new external URLs

URL: /en-US/docs/Learn/JavaScript/Client-side_web_APIs/Third_party_APIs
Title: Third-party APIs
on GitHub

No new external URLs

URL: /en-US/docs/Learn/JavaScript/Objects/Object_prototypes
Title: Object prototypes
on GitHub

No new external URLs

URL: /en-US/docs/Learn/JavaScript/Building_blocks/Test_your_skills:_Conditionals
Title: Test your skills: Conditionals
on GitHub

No new external URLs

URL: /en-US/docs/Learn/JavaScript/Building_blocks/Test_your_skills:_Events
Title: Test your skills: Events
on GitHub

No new external URLs

URL: /en-US/docs/Learn/JavaScript/First_steps/What_is_JavaScript
Title: What is JavaScript?
on GitHub

No new external URLs

URL: /en-US/docs/Learn/JavaScript/First_steps/What_went_wrong
Title: What went wrong? Troubleshooting JavaScript
on GitHub

No new external URLs

URL: /en-US/docs/Learn/JavaScript/First_steps/Strings
Title: Handling text — strings in JavaScript
on GitHub

No new external URLs

URL: /en-US/docs/Learn/JavaScript/First_steps/Useful_string_methods
Title: Useful string methods
on GitHub

No new external URLs

URL: /en-US/docs/Learn/Tools_and_testing/Client-side_JavaScript_frameworks/Ember_interactivity_events_state
Title: Ember interactivity: Events, classes and state
on GitHub

No new external URLs

URL: /en-US/docs/Learn/Tools_and_testing/Client-side_JavaScript_frameworks/Main_features
Title: Framework main features
on GitHub

No new external URLs

(this comment was updated 2022-07-13 05:21:52.249322)

teoli2003
teoli2003 suggested changes Jul 13, 2022
View reviewed changes
files/en-us/learn/javascript/client-side_web_apis/client-side_storage/index.md Outdated Show resolved Hide resolved
files/en-us/learn/javascript/client-side_web_apis/third_party_apis/index.md Outdated Show resolved Hide resolved
files/en-us/learn/javascript/first_steps/useful_string_methods/index.md Outdated Show resolved Hide resolved
files/en-us/learn/server-side/django/deployment/index.md Outdated Show resolved Hide resolved
files/en-us/learn/server-side/django/deployment/index.md Outdated Show resolved Hide resolved
files/en-us/learn/server-side/django/skeleton_website/index.md Outdated Show resolved Hide resolved
files/en-us/learn/server-side/django/testing/index.md Outdated Show resolved Hide resolved
files/en-us/learn/server-side/express_nodejs/deployment/index.md Outdated Show resolved Hide resolved
files/en-us/learn/server-side/express_nodejs/deployment/index.md Outdated Show resolved Hide resolved
files/en-us/learn/server-side/first_steps/web_frameworks/index.md Outdated Show resolved Hide resolved
OnkarRuikar and others added 2 commits July 13, 2022 10:48
teoli2003
teoli2003 approved these changes Jul 13, 2022
View reviewed changes
Copy link
Contributor

@teoli2003 teoli2003 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

👍

@teoli2003 teoli2003 merged commit 3a42980 into mdn:main Jul 13, 2022
@OnkarRuikar
Copy link
Contributor Author

GitHub has a bug: it isn't showing first review comment in 'Files Changed' tab.
These days I have to commit first suggestions from the main('Conversation') tab. 🫤

@OnkarRuikar OnkarRuikar deleted the code-ellipsis3 branch July 13, 2022 05:23
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@teoli2003 teoli2003 teoli2003 approved these changes

Assignees
No one assigned
Labels
Content:Learn Learning area docs
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@OnkarRuikar @teoli2003