Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Comment out ellipsis in code blocks, part 4 #18296

Merged
merged 3 commits into from
Jul 13, 2022
Merged

Comment out ellipsis in code blocks, part 4 #18296

merged 3 commits into from
Jul 13, 2022

Conversation

OnkarRuikar
Copy link
Contributor

Adding to #18206.

Ellipsis in markdown code blocks are syntax errors.
In order to have smooth transition to Prettier and ESLint the PR comments out such bare ellipses.

@OnkarRuikar OnkarRuikar requested review from a team as code owners July 13, 2022 02:45
@OnkarRuikar OnkarRuikar requested review from rebloor and Rumyra and removed request for a team July 13, 2022 02:45
@github-actions github-actions bot added Content:Learn Learning area docs Content:Other Any docs not covered by another "Content:" label Content:WebExt WebExtensions docs labels Jul 13, 2022
@github-actions
Copy link
Contributor

github-actions bot commented Jul 13, 2022 •
edited
Loading

Preview URLs

Flaws

Note! 15 documents with no flaws that don't need to be listed. 🎉

URL: /en-US/docs/Learn/Tools_and_testing/Client-side_JavaScript_frameworks/Svelte_stores
Title: Working with Svelte stores
on GitHub
Flaw count: 1

  • broken_links:
    • Link points to the page it's already on

URL: /en-US/docs/Learn/Tools_and_testing/Client-side_JavaScript_frameworks/React_interactivity_filtering_conditional_rendering
Title: React interactivity: Editing, filtering, conditional rendering
on GitHub
Flaw count: 1

  • broken_links:
    • Link points to the page it's already on

URL: /en-US/docs/Learn/Tools_and_testing/Client-side_JavaScript_frameworks/Svelte_deployment_next
Title: Deployment and next steps
on GitHub
Flaw count: 1

  • broken_links:
    • Link points to the page it's already on

URL: /en-US/docs/Learn/Tools_and_testing/Client-side_JavaScript_frameworks/Svelte_components
Title: Componentizing our Svelte app
on GitHub
Flaw count: 1

  • broken_links:
    • Link points to the page it's already on

URL: /en-US/docs/Learn/Tools_and_testing/Client-side_JavaScript_frameworks/Svelte_reactivity_lifecycle_accessibility
Title: Advanced Svelte: Reactivity, lifecycle, accessibility
on GitHub
Flaw count: 1

  • broken_links:
    • Link points to the page it's already on

URL: /en-US/docs/Learn/Tools_and_testing/Client-side_JavaScript_frameworks/Svelte_Todo_list_beginning
Title: Starting our Svelte to-do list app
on GitHub
Flaw count: 1

  • broken_links:
    • Link points to the page it's already on

URL: /en-US/docs/Learn/Tools_and_testing/Client-side_JavaScript_frameworks/Svelte_getting_started
Title: Getting started with Svelte
on GitHub
Flaw count: 1

  • broken_links:
    • Link points to the page it's already on

URL: /en-US/docs/Learn/Tools_and_testing/Client-side_JavaScript_frameworks/Svelte_variables_props
Title: Dynamic behavior in Svelte: working with variables and props
on GitHub
Flaw count: 1

  • broken_links:
    • Link points to the page it's already on

URL: /en-US/docs/Learn/Tools_and_testing/Cross_browser_testing/Your_own_automation_environment
Title: Setting up your own test automation environment
on GitHub
Flaw count: 1

  • broken_links:
    • Link points to the page it's already on

URL: /en-US/docs/Learn/Tools_and_testing/Cross_browser_testing/Feature_detection
Title: Implementing feature detection
on GitHub
Flaw count: 1

  • broken_links:
    • Link points to the page it's already on

URL: /en-US/docs/Learn/Tools_and_testing/Cross_browser_testing/Automated_testing
Title: Introduction to automated testing
on GitHub
Flaw count: 1

  • broken_links:
    • Link points to the page it's already on

URL: /en-US/docs/Learn/Tools_and_testing/Cross_browser_testing/JavaScript
Title: Handling common JavaScript problems
on GitHub
Flaw count: 2

  • broken_links:
    • Can't resolve /en-US/docs/Web/API/GlobalEventHandlers/onclick
    • Link points to the page it's already on

URL: /en-US/docs/Learn/Tools_and_testing/Understanding_client-side_tools/Deployment
Title: Deploying our app
on GitHub
Flaw count: 1

  • broken_links:
    • Link points to the page it's already on

URL: /en-US/docs/MDN/Contribute/Howto/Write_an_API_reference/Information_contained_in_a_WebIDL_file
Title: Information contained in a WebIDL file
on GitHub
Flaw count: 1

  • broken_links:
    • Can't resolve /en-US/docs/Mozilla/WebIDL_bindings#exposed

URL: /en-US/docs/MDN/Structures/Page_types/API_constructor_subpage_template
Title: API constructor subpage template
on GitHub
Flaw count: 3

  • macros:
    • /en-us/docs/web/api/mdn (url: /en-US/docs/Web/API/MDN) does not exist
    • /en-US/docs/Web/API/NameOfTheParentInterface does not exist
  • bad_bcd_queries:
    • No BCD data for query: path.to.feature.NameOfTheConstructor

External URLs

URL: /en-US/docs/Mozilla/Add-ons/WebExtensions/Internationalization
Title: Internationalization
on GitHub

No new external URLs

URL: /en-US/docs/Mozilla/Add-ons/WebExtensions/Extending_the_developer_tools
Title: Extending the developer tools
on GitHub

No new external URLs

URL: /en-US/docs/Mozilla/Add-ons/WebExtensions/Build_a_cross_browser_extension
Title: Building a cross-browser extension
on GitHub

No new external URLs

URL: /en-US/docs/Mozilla/Add-ons/WebExtensions/Content_scripts
Title: Content scripts
on GitHub

No new external URLs

URL: /en-US/docs/Mozilla/Add-ons/WebExtensions/API/extension/onRequest
Title: extension.onRequest
on GitHub

No new external URLs

URL: /en-US/docs/Mozilla/Add-ons/WebExtensions/API/notifications/update
Title: notifications.update()
on GitHub

No new external URLs

URL: /en-US/docs/Mozilla/Add-ons/WebExtensions/API/privacy/network
Title: privacy.network
on GitHub

No new external URLs

URL: /en-US/docs/Mozilla/Add-ons/WebExtensions/API/runtime/Port
Title: runtime.Port
on GitHub

No new external URLs

URL: /en-US/docs/Mozilla/Add-ons/WebExtensions/API/bookmarks/onImportBegan
Title: bookmarks.onImportBegan
on GitHub

No new external URLs

URL: /en-US/docs/Mozilla/Add-ons/WebExtensions/API/bookmarks/onImportEnded
Title: bookmarks.onImportEnded
on GitHub

No new external URLs

URL: /en-US/docs/Mozilla/Add-ons/WebExtensions/API/menus/onShown
Title: menus.onShown
on GitHub

No new external URLs

URL: /en-US/docs/Mozilla/Add-ons/WebExtensions/API/userScripts/onBeforeScript
Title: userScripts.onBeforeScript
on GitHub

No new external URLs

URL: /en-US/docs/Learn/Tools_and_testing/Client-side_JavaScript_frameworks/Svelte_stores
Title: Working with Svelte stores
on GitHub

No new external URLs

URL: /en-US/docs/Learn/Tools_and_testing/Client-side_JavaScript_frameworks/React_interactivity_filtering_conditional_rendering
Title: React interactivity: Editing, filtering, conditional rendering
on GitHub

No new external URLs

URL: /en-US/docs/Learn/Tools_and_testing/Client-side_JavaScript_frameworks/Svelte_deployment_next
Title: Deployment and next steps
on GitHub

No new external URLs

URL: /en-US/docs/Learn/Tools_and_testing/Client-side_JavaScript_frameworks/Svelte_components
Title: Componentizing our Svelte app
on GitHub

No new external URLs

URL: /en-US/docs/Learn/Tools_and_testing/Client-side_JavaScript_frameworks/Svelte_reactivity_lifecycle_accessibility
Title: Advanced Svelte: Reactivity, lifecycle, accessibility
on GitHub

URL: /en-US/docs/Learn/Tools_and_testing/Client-side_JavaScript_frameworks/Svelte_Todo_list_beginning
Title: Starting our Svelte to-do list app
on GitHub

No new external URLs

URL: /en-US/docs/Learn/Tools_and_testing/Client-side_JavaScript_frameworks/Svelte_getting_started
Title: Getting started with Svelte
on GitHub

URL: /en-US/docs/Learn/Tools_and_testing/Client-side_JavaScript_frameworks/Svelte_variables_props
Title: Dynamic behavior in Svelte: working with variables and props
on GitHub

URL: /en-US/docs/Learn/Tools_and_testing/Cross_browser_testing/Your_own_automation_environment
Title: Setting up your own test automation environment
on GitHub

No new external URLs

URL: /en-US/docs/Learn/Tools_and_testing/Cross_browser_testing/Feature_detection
Title: Implementing feature detection
on GitHub

No new external URLs

URL: /en-US/docs/Learn/Tools_and_testing/Cross_browser_testing/Automated_testing
Title: Introduction to automated testing
on GitHub

No new external URLs

URL: /en-US/docs/Learn/Tools_and_testing/Cross_browser_testing/JavaScript
Title: Handling common JavaScript problems
on GitHub

No new external URLs

URL: /en-US/docs/Learn/Tools_and_testing/Understanding_client-side_tools/Deployment
Title: Deploying our app
on GitHub

No new external URLs

URL: /en-US/docs/MDN/Contribute/Howto/Write_an_API_reference/Information_contained_in_a_WebIDL_file
Title: Information contained in a WebIDL file
on GitHub

No new external URLs

URL: /en-US/docs/MDN/Structures/Page_types/API_constructor_subpage_template
Title: API constructor subpage template
on GitHub

No new external URLs

URL: /en-US/docs/MDN/Guidelines/Code_guidelines/General
Title: General guidelines for all code
on GitHub

No new external URLs

URL: /en-US/docs/MDN/Guidelines/Code_guidelines/JavaScript
Title: JavaScript guidelines
on GitHub

No new external URLs

URL: /en-US/docs/MDN/Guidelines/Code_guidelines/CSS
Title: CSS guidelines
on GitHub

No new external URLs

(this comment was updated 2022-07-13 05:04:58.727188)

teoli2003
teoli2003 suggested changes Jul 13, 2022
View reviewed changes
...testing/client-side_javascript_frameworks/svelte_reactivity_lifecycle_accessibility/index.md Outdated Show resolved Hide resolved
...earn/tools_and_testing/client-side_javascript_frameworks/svelte_todo_list_beginning/index.md Outdated Show resolved Hide resolved
files/en-us/learn/tools_and_testing/cross_browser_testing/feature_detection/index.md Outdated Show resolved Hide resolved
files/en-us/learn/tools_and_testing/cross_browser_testing/javascript/index.md Outdated Show resolved Hide resolved
.../mdn/contribute/howto/write_an_api_reference/information_contained_in_a_webidl_file/index.md Outdated Show resolved Hide resolved
files/en-us/mozilla/add-ons/webextensions/api/menus/onshown/index.md Outdated Show resolved Hide resolved
OnkarRuikar and others added 2 commits July 13, 2022 10:31
@OnkarRuikar @teoli2003
Apply suggestions from code review
944eb5c 
Co-authored-by: Jean-Yves Perrier <[email protected]>
@OnkarRuikar @teoli2003
Update files/en-us/learn/tools_and_testing/client-side_javascript_fra…
6b42872 
…meworks/svelte_reactivity_lifecycle_accessibility/index.md

Co-authored-by: Jean-Yves Perrier <[email protected]>
teoli2003
teoli2003 approved these changes Jul 13, 2022
View reviewed changes
Copy link
Contributor

@teoli2003 teoli2003 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thank you!

@teoli2003 teoli2003 merged commit 8fed552 into mdn:main Jul 13, 2022
@OnkarRuikar OnkarRuikar deleted the code-ellipsis4 branch July 13, 2022 05:10
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@teoli2003 teoli2003 teoli2003 approved these changes

@rebloor rebloor Awaiting requested review from rebloor rebloor is a code owner automatically assigned from mdn/yari-content-mozilla-add-ons

@Rumyra Rumyra Awaiting requested review from Rumyra Rumyra is a code owner automatically assigned from mdn/yari-content-mdn

Assignees
No one assigned
Labels
Content:Learn Learning area docs Content:Other Any docs not covered by another "Content:" label Content:WebExt WebExtensions docs
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@OnkarRuikar @teoli2003