Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Comment out ellipsis in code blocks, part 5 #18341

Merged
merged 3 commits into from
Jul 14, 2022
Merged

Comment out ellipsis in code blocks, part 5 #18341

merged 3 commits into from
Jul 14, 2022

Conversation

OnkarRuikar
Copy link
Contributor

Adding to #18206.

Ellipsis in markdown code blocks are syntax errors.
In order to have smooth transition to Prettier and ESLint the PR comments out such bare ellipses.

@OnkarRuikar OnkarRuikar requested review from a team as code owners July 14, 2022 03:08
@OnkarRuikar OnkarRuikar requested review from rebloor, hidde and Rumyra and removed request for a team July 14, 2022 03:08
@github-actions github-actions bot added Content:Accessibility Accessibility docs Content:Other Any docs not covered by another "Content:" label Content:WebExt WebExtensions docs labels Jul 14, 2022
@github-actions
Copy link
Contributor

github-actions bot commented Jul 14, 2022 •
edited
Loading

Preview URLs

Flaws

Note! 14 documents with no flaws that don't need to be listed. 🎉

URL: /en-US/docs/Mozilla/Firefox/Releases/5/Updating_add-ons
Title: Updating add-ons for Firefox 5
on GitHub
Flaw count: 3

  • macros:
    • /en-US/docs/Web/API/Window/navigator/language does not exist
  • broken_links:
    • Can't resolve /en-US/docs/Mozilla/Developer_guide/Interface_Compatibility#binary_interfaces
    • Can't resolve /en-US/docs/Extensions/Performance_best_practices_in_extensions

URL: /en-US/docs/Mozilla/Firefox/Releases/20
Title: Firefox 20 for developers
on GitHub
Flaw count: 6

  • macros:
    • /en-US/docs/Web/API/TableRow/insertCell does not exist
    • /en-US/docs/Web/API/Table/insertRow does not exist
    • /en-US/docs/Web/API/Transferable does not exist
  • broken_links:
    • Can't resolve /en-US/docs/JavaScript/Reference/Statements/for_each...in
    • Can't resolve /en-US/docs/Error_Console
    • Can't resolve /en-US/docs/E4X

URL: /en-US/docs/Mozilla/Firefox/Releases/3/Updating_web_applications
Title: Updating web applications for Firefox 3
on GitHub
Flaw count: 3

  • broken_links:
    • Can't resolve /en-US/docs/Same-origin_policy_for_file:_URIs
    • Can't resolve /en-US/docs/New_in_JavaScript_1.8
    • Can't resolve /en-US/docs/New_in_JavaScript_1.8

URL: /en-US/docs/Web/Accessibility/ARIA/Attributes/aria-colcount
Title: aria-colcount
on GitHub
Flaw count: 1

  • broken_links:
    • Can't resolve /en-US/docs/Web/Accessibility/ARIA/Role/Table_role/

URL: /en-US/docs/Web/Accessibility/ARIA/Annotations
Title: ARIA annotations
on GitHub
Flaw count: 1

  • broken_links:
    • Can't resolve /en-US/docs/Web/Accessibility/ARIA/ARIA_Techniques/Using_the_aria-label_attribute

URL: /en-US/docs/Web/Accessibility/ARIA/ARIA_Live_Regions
Title: ARIA live regions
on GitHub
Flaw count: 1

  • broken_links:
    • Can't resolve /en-US/docs/Web/Accessibility/ARIA/ARIA_Techniques/Using_the_aria-relevant_attribute

URL: /en-US/docs/MDN/Structures/Page_types/HTML_element_page_template
Title: HTML element page template
on GitHub
Flaw count: 2

  • macros:
    • wrong xref macro used (consider changing which macro you use)
  • bad_bcd_queries:
    • No BCD data for query: path.to.feature.NameOfTheElement

URL: /en-US/docs/MDN/Structures/Page_types/API_landing_page_template
Title: API landing page template
on GitHub
Flaw count: 6

  • macros:
    • /en-us/docs/web/api/mdn (url: /en-US/docs/Web/API/MDN) does not exist
    • /en-US/docs/Web/API/NameOfTheInterface does not exist
    • /en-US/docs/Web/API/Addition1 does not exist
    • /en-US/docs/Web/API/Addition1 does not exist
  • bad_bcd_queries:
    • No BCD data for query: path.to.feature.Interface_1
    • No BCD data for query: path.to.feature.Interface_2

URL: /en-US/docs/MDN/Structures/Page_types/CSS_selector_page_template
Title: CSS selector page template
on GitHub
Flaw count: 1

  • bad_bcd_queries:
    • No BCD data for query: css.selectors.NameOfTheSelector

URL: /en-US/docs/MDN/Structures/Page_types/API_method_subpage_template
Title: API method subpage template
on GitHub
Flaw count: 2

  • macros:
    • /en-us/docs/web/api/mdn (url: /en-US/docs/Web/API/MDN) does not exist
  • bad_bcd_queries:
    • No BCD data for query: path.to.feature.NameOfTheMethod

URL: /en-US/docs/MDN/Structures/Page_types/API_event_subpage_template
Title: API event subpage template
on GitHub
Flaw count: 3

  • macros:
    • /en-us/docs/web/api/mdn (url: /en-US/docs/Web/API/MDN) does not exist
  • broken_links:
    • Can't resolve /en-US/docs/Web/API/Window/animationcancel_event
  • bad_bcd_queries:
    • No BCD data for query: path.to.feature.NameOfTheEvent_event

URL: /en-US/docs/MDN/Structures/Page_types/API_reference_page_template
Title: API reference page template
on GitHub
Flaw count: 10

  • macros:
    • /en-us/docs/web/api/mdn (url: /en-US/docs/Web/API/MDN) does not exist
    • /en-US/docs/Web/API/NameOfTheInterface/NameOfTheInterface does not exist
    • /en-US/docs/Web/API/NameOfTheInterface does not exist
    • /en-US/docs/Web/API/NameOfParentInterface does not exist
    • /en-US/docs/Web/API/NameOfTheInterface/property1 does not exist
    • and 4 more flaws omitted
  • bad_bcd_queries:
    • No BCD data for query: path.to.feature.NameOfTheInterface

URL: /en-US/docs/MDN/Structures/Page_types/API_property_subpage_template
Title: API property subpage template
on GitHub
Flaw count: 2

  • macros:
    • /en-us/docs/web/api/mdn (url: /en-US/docs/Web/API/MDN) does not exist
  • bad_bcd_queries:
    • No BCD data for query: path.to.feature.NameOfTheProperty

URL: /en-US/docs/MDN/Structures/Page_types/HTTP_header_page_template
Title: HTTP header page template
on GitHub
Flaw count: 1

  • bad_bcd_queries:
    • No BCD data for query: path.to.feature.NameOfTheHeader

URL: /en-US/docs/MDN/Structures/Page_types/CSS_property_page_template
Title: CSS property page template
on GitHub
Flaw count: 3

  • macros:
    • /en-US/docs/Web/CSS/subvalue1 does not exist
    • /en-US/docs/Web/CSS/subvalue2 does not exist
  • bad_bcd_queries:
    • No BCD data for query: css.properties.NameOfTheProperty

URL: /en-US/docs/MDN/Structures/Page_types/SVG_element_page_template
Title: SVG element page template
on GitHub
Flaw count: 2

  • macros:
    • /en-US/docs/Web/API/NameOfSVGDOMElement does not exist
  • bad_bcd_queries:
    • No BCD data for query: path.to.feature.NameOfTheElement

External URLs

URL: /en-US/docs/Related/IMSC
Title: IMSC: subtitles and captioning for the Web
on GitHub

No new external URLs

URL: /en-US/docs/Related/IMSC/Mapping_video_time_codes_to_IMSC
Title: Mapping video time codes to IMSC
on GitHub

No new external URLs

URL: /en-US/docs/Mozilla/Add-ons/WebExtensions/manifest.json
Title: manifest.json
on GitHub

No new external URLs

URL: /en-US/docs/Mozilla/Add-ons/WebExtensions/manifest.json/web_accessible_resources
Title: web_accessible_resources
on GitHub

No new external URLs

URL: /en-US/docs/Mozilla/Add-ons/WebExtensions/manifest.json/version/format
Title: Manifest Version Format
on GitHub

No new external URLs

URL: /en-US/docs/Mozilla/Add-ons/WebExtensions/Native_messaging
Title: Native messaging
on GitHub

No new external URLs

URL: /en-US/docs/Mozilla/Add-ons/WebExtensions/API/extension/onRequestExternal
Title: extension.onRequestExternal
on GitHub

No new external URLs

URL: /en-US/docs/Mozilla/Add-ons/WebExtensions/API/extension/sendRequest
Title: extension.sendRequest()
on GitHub

No new external URLs

URL: /en-US/docs/Mozilla/Add-ons/WebExtensions/API/menus/create
Title: menus.create()
on GitHub

No new external URLs

URL: /en-US/docs/Mozilla/Add-ons/WebExtensions/API/events/UrlFilter
Title: events.UrlFilter
on GitHub

No new external URLs

URL: /en-US/docs/Mozilla/Add-ons/WebExtensions/user_interface/Context_menu_items
Title: Context menu items
on GitHub

No new external URLs

URL: /en-US/docs/Mozilla/Firefox/Releases/5/Updating_add-ons
Title: Updating add-ons for Firefox 5
on GitHub

No new external URLs

URL: /en-US/docs/Mozilla/Firefox/Releases/20
Title: Firefox 20 for developers
on GitHub

No new external URLs

URL: /en-US/docs/Mozilla/Firefox/Releases/3/Updating_web_applications
Title: Updating web applications for Firefox 3
on GitHub

No new external URLs

URL: /en-US/docs/Web/Accessibility/ARIA/Attributes/aria-colcount
Title: aria-colcount
on GitHub

No new external URLs

URL: /en-US/docs/Web/Accessibility/ARIA/Annotations
Title: ARIA annotations
on GitHub

No new external URLs

URL: /en-US/docs/Web/Accessibility/ARIA/ARIA_Live_Regions
Title: ARIA live regions
on GitHub

No new external URLs

URL: /en-US/docs/MDN/Structures/Page_types/HTML_element_page_template
Title: HTML element page template
on GitHub

No new external URLs

URL: /en-US/docs/MDN/Structures/Page_types/ARIA_Page_Template
Title: ARIA page template
on GitHub

No new external URLs

URL: /en-US/docs/MDN/Structures/Page_types/API_landing_page_template
Title: API landing page template
on GitHub

No new external URLs

URL: /en-US/docs/MDN/Structures/Page_types/CSS_selector_page_template
Title: CSS selector page template
on GitHub

No new external URLs

URL: /en-US/docs/MDN/Structures/Page_types/API_method_subpage_template
Title: API method subpage template
on GitHub

No new external URLs

URL: /en-US/docs/MDN/Structures/Page_types/API_event_subpage_template
Title: API event subpage template
on GitHub

No new external URLs

URL: /en-US/docs/MDN/Structures/Page_types/API_reference_page_template
Title: API reference page template
on GitHub

No new external URLs

URL: /en-US/docs/MDN/Structures/Page_types/API_property_subpage_template
Title: API property subpage template
on GitHub

No new external URLs

URL: /en-US/docs/MDN/Structures/Page_types/HTTP_header_page_template
Title: HTTP header page template
on GitHub

No new external URLs

URL: /en-US/docs/MDN/Structures/Page_types/CSS_property_page_template
Title: CSS property page template
on GitHub

No new external URLs

URL: /en-US/docs/MDN/Structures/Page_types/SVG_element_page_template
Title: SVG element page template
on GitHub

No new external URLs

URL: /en-US/docs/MDN/Structures/Syntax_sections
Title: Syntax sections
on GitHub

No new external URLs

URL: /en-US/docs/MDN/Tools/KumaScript
Title: KumaScript
on GitHub

No new external URLs

(this comment was updated 2022-07-14 05:32:22.488977)

teoli2003
teoli2003 suggested changes Jul 14, 2022
View reviewed changes
Copy link
Contributor

@teoli2003 teoli2003 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thank you!

files/en-us/mozilla/add-ons/webextensions/manifest.json/version/format/index.md Outdated Show resolved Hide resolved
files/en-us/mozilla/firefox/releases/3/updating_web_applications/index.md Outdated Show resolved Hide resolved
files/en-us/mozilla/firefox/releases/3/updating_web_applications/index.md Outdated Show resolved Hide resolved
files/en-us/related/imsc/mapping_video_time_codes_to_imsc/index.md Outdated Show resolved Hide resolved
files/en-us/web/accessibility/aria/annotations/index.md Outdated Show resolved Hide resolved
OnkarRuikar and others added 2 commits July 14, 2022 10:59
@teoli2003 teoli2003 merged commit 8b51c99 into mdn:main Jul 14, 2022
@OnkarRuikar OnkarRuikar deleted the code-ellipsis5 branch July 14, 2022 05:40
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@teoli2003 teoli2003 teoli2003 approved these changes

@rebloor rebloor Awaiting requested review from rebloor rebloor is a code owner automatically assigned from mdn/yari-content-mozilla-add-ons

@hidde hidde Awaiting requested review from hidde hidde is a code owner automatically assigned from mdn/yari-content-accessibility

@Rumyra Rumyra Awaiting requested review from Rumyra Rumyra is a code owner automatically assigned from mdn/yari-content-mdn

Assignees
No one assigned
Labels
Content:Accessibility Accessibility docs Content:Other Any docs not covered by another "Content:" label Content:WebExt WebExtensions docs
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@OnkarRuikar @teoli2003