Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

no more vars in Web/API (2) #18864

Merged
merged 6 commits into from
Jul 28, 2022
Merged

no more vars in Web/API (2) #18864

merged 6 commits into from
Jul 28, 2022

Commits on Jul 27, 2022

  1. no more vars in Web/API 

    * See mdn#16662
* See #10389
* See https://github.com/orgs/mdn/discussions/143
* Mostly automated via my ESLint setup, using the rules 'no-var' and 'prefer-const'
    @lionralfs
    lionralfs committed Jul 27, 2022
    Configuration menu
    Copy the full SHA
    eb56910 View commit details
    Browse the repository at this point in the history

  2. split var declarations into 2 lines, rename them

    @lionralfs
    lionralfs committed Jul 27, 2022
    Configuration menu
    Copy the full SHA
    0396b78 View commit details
    Browse the repository at this point in the history

  3. Apply suggestions from code review 

    Co-authored-by: rubiesonthesky <[email protected]>
    @lionralfs @rubiesonthesky
    lionralfs and rubiesonthesky authored Jul 27, 2022
    Configuration menu
    Copy the full SHA
    2f2b92d View commit details
    Browse the repository at this point in the history

  4. keep var in polyfills

    @lionralfs
    lionralfs committed Jul 27, 2022
    Configuration menu
    Copy the full SHA
    57fca2d View commit details
    Browse the repository at this point in the history

Commits on Jul 28, 2022

  1. Apply suggestions from code review 

    Co-authored-by: Jean-Yves Perrier <[email protected]>
    @lionralfs @teoli2003
    lionralfs and teoli2003 authored Jul 28, 2022
    Configuration menu
    Copy the full SHA
    3e25a80 View commit details
    Browse the repository at this point in the history

  2. Merge branch 'main' into no-var-2

    @lionralfs
    lionralfs authored Jul 28, 2022
    Configuration menu
    Copy the full SHA
    8d0943a View commit details
    Browse the repository at this point in the history