Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Add API overview page for Device Orientation Events #20385

Merged
merged 2 commits into from
Sep 7, 2022
Merged

Add API overview page for Device Orientation Events #20385

merged 2 commits into from
Sep 7, 2022

Conversation

sideshowbarker
Copy link
Collaborator

@sideshowbarker sideshowbarker commented Sep 7, 2022 •
edited
Loading

Fixes #2644. Note that this intentionally omits the “compassneedscalibration” event — because:

@sideshowbarker sideshowbarker requested review from a team as code owners September 7, 2022 08:34
@sideshowbarker sideshowbarker requested review from wbamberg and teoli2003 and removed request for a team September 7, 2022 08:34
@github-actions github-actions bot added the Content:WebAPI Web API docs label Sep 7, 2022
@github-actions

This comment was marked as outdated.

Sign in to view
@sideshowbarker sideshowbarker force-pushed the sideshowbarker/device-orientation-events-overview branch 3 times, most recently from 49ad20a to 7c58f29 Compare September 7, 2022 09:10
teoli2003
teoli2003 approved these changes Sep 7, 2022
View reviewed changes
Copy link
Contributor

@teoli2003 teoli2003 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

👍

@github-actions github-actions bot added Content:Learn Learning area docs Content:Other Any docs not covered by another "Content:" label labels Sep 7, 2022
@teoli2003
Copy link
Contributor

You should run yarn install the latest yari shouldn't generate the JSON lint error.

@sideshowbarker sideshowbarker force-pushed the sideshowbarker/device-orientation-events-overview branch from 7c58f29 to e85344a Compare September 7, 2022 09:13
@sideshowbarker sideshowbarker requested a review from a team as a code owner September 7, 2022 09:13
@sideshowbarker sideshowbarker requested review from dipikabh and removed request for a team September 7, 2022 09:13
@github-actions github-actions bot added the Content:CSS Cascading Style Sheets docs label Sep 7, 2022
@sideshowbarker
Copy link
Collaborator Author

You should run yarn install the latest yari shouldn't generate the JSON lint error.

ah OK yeah will do that right now

@sideshowbarker sideshowbarker force-pushed the sideshowbarker/device-orientation-events-overview branch from e85344a to 0834132 Compare September 7, 2022 09:21
@teoli2003 teoli2003 merged commit 5977c48 into main Sep 7, 2022
@teoli2003 teoli2003 deleted the sideshowbarker/device-orientation-events-overview branch September 7, 2022 09:23
himanshugarg pushed a commit to himanshugarg/content that referenced this pull request Sep 27, 2022
@sideshowbarker
Add API overview page for Device Orientation Events (mdn#20385)
91b2e02 
* Add API overview page for Device Orientation Events

Fixes mdn#2644

* Update all links to the existing guide pages we moved
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@teoli2003 teoli2003 teoli2003 approved these changes

@wbamberg wbamberg Awaiting requested review from wbamberg wbamberg is a code owner automatically assigned from mdn/yari-content-web-api

@dipikabh dipikabh Awaiting requested review from dipikabh dipikabh is a code owner automatically assigned from mdn/yari-content-css

Assignees
No one assigned
Labels
Content:CSS Cascading Style Sheets docs Content:Learn Learning area docs Content:Other Any docs not covered by another "Content:" label Content:WebAPI Web API docs
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Add API overview page for Device Orientation Events
2 participants
@sideshowbarker @teoli2003