Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Remove slottable mixin #2216

Merged
merged 8 commits into from
Feb 10, 2021
Merged

Remove slottable mixin #2216

merged 8 commits into from
Feb 10, 2021

Conversation

Elchi3
Copy link
Member

@Elchi3 Elchi3 commented Feb 9, 2021

Analog to mdn/browser-compat-data#9048

This time, yarn content move worked as expected. I might have forgotten to run "yarn" from my content folder in the other mixin PR (it is easy to miss).

Anyway, here's another mixin to avoid. For the Text interface it was mostly correct as is already.

I made a few sensible commits which could be preserved (or not, your choice). It didn't make sense to me to put the steps in separate PRs.

@Elchi3 Elchi3 requested review from a team as code owners February 9, 2021 16:44
@Elchi3 Elchi3 requested review from chrisdavidmills and removed request for a team February 9, 2021 16:44
Copy link
Contributor

@chrisdavidmills chrisdavidmills left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Again, looking good Mr Scholz.

A few points:

  1. Surely /en-US/docs/Web/API/Slottable should redirect to /en-US/docs/Web/API/Element? It currently redirects to nowhere.

  2. Same comment as for the other review about possibly providing a note in the spec table to say that the property is in fact defined on a mixin, just in case?

  3. Text/assignedSlot shouldn't have the experimental banner at the top of it.

@Elchi3
Copy link
Member Author

Elchi3 commented Feb 10, 2021

Again, looking good Mr Scholz.

A few points:

  1. Surely /en-US/docs/Web/API/Slottable should redirect to /en-US/docs/Web/API/Element? It currently redirects to nowhere.

done by doing yarn content add-redirect /en-US/docs/Web/API/Slottable /en-US/docs/Web/API/Element

  1. Same comment as for the other review about possibly providing a note in the spec table to say that the property is in fact defined on a mixin, just in case?

Hm, I'm not sure about this one. I think we want to autogenerate the spec section from BCD one day (without comments) and also if you are wondering about mixins you are likely already familiar with the spec?

  1. Text/assignedSlot shouldn't have the experimental banner at the top of it.

Removed :)

Copy link
Contributor

@chrisdavidmills chrisdavidmills left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Yay, all looks good to me!

I don't feel that strongly about the mixin note thing; happy to leave that alone. You are right that it would make auto-generation harder.

@chrisdavidmills chrisdavidmills merged commit 0e626a4 into mdn:main Feb 10, 2021
@Elchi3 Elchi3 deleted the demix-slottable branch February 10, 2021 13:30
@Elchi3 Elchi3 mentioned this pull request Feb 11, 2021
@Elchi3 Elchi3 mentioned this pull request Mar 3, 2021
@github-actions github-actions bot locked as resolved and limited conversation to collaborators Aug 28, 2022
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants