Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix(ci): do not paginate for fetching file changes #22898

Merged
merged 1 commit into from
Dec 12, 2022
Merged

fix(ci): do not paginate for fetching file changes #22898

merged 1 commit into from
Dec 12, 2022

Conversation

yin1999
Copy link
Member

@yin1999 yin1999 commented Dec 12, 2022

Description

ci: do not paginate for fetching file changes. For the paginated API call's response will not contain the files field (all in the first call).

Motivation

See https://github.com/mdn/content/actions/runs/3673568856/jobs/6210798159

Related issues and pull requests

#22439

@yin1999
Copy link
Member Author

yin1999 commented Dec 12, 2022

Output of gh api repos/{owner}/{repo}/compare/21ba511d004c2e881f42f65248a5a00db2a6c1e2...c13d8e7bbd3568dd7633e9ac7c6dfbcce8144c7f --paginate > out.json

See line 9910

out.zip

Copy link
Contributor

@caugner caugner left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM, indeed gh api repos/{owner}/{repo}/compare/21ba511d004c2e881f42f65248a5a00db2a6c1e2...c13d8e7bbd3568dd7633e9ac7c6dfbcce8144c7f | jq '.files | .[].filename' | wc -l lists all 153 changed files, so no need to paginate. 🙂

@caugner caugner changed the title ci: do not paginate for fetching file changes fix(ci): do not paginate for fetching file changes Dec 12, 2022
@caugner caugner merged commit 820fa56 into mdn:main Dec 12, 2022
@yin1999 yin1999 deleted the fix-api branch December 12, 2022 11:46
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants