array.slice syntax #2351
Merged
array.slice syntax #2351
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
As discussed in mdn#2202 (comment)
|
@Elchi3 Ready for review at your convenience. Note, though slightly wondering if return type |
Elchi3
approved these changes
Feb 16, 2021
There was a problem hiding this comment.
Thanks @hamishwillee, as said in the issue, I would prefer to do one thing after the other, so I think lets first merge multiple lines and iterate further once this has proven itself. Hope that makes sense to you.
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Syntax fixes to "test" #2202
Comment or not comment the syntax