Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Document Document.activeElement and ShadowRoot.activeElement separately. #2395

Merged

Conversation

Elchi3
Copy link
Member

@Elchi3 Elchi3 commented Feb 16, 2021

The https://developer.mozilla.org/en-US/docs/Web/API/DocumentOrShadowRoot mixin is a bit larger, so I'm not sure how to make PRs reviewable, but I thought maybe going member by member makes sense.

So, this PR updates the docs so that we have Document.activeElement and ShadowRoot.activeElement separately instead of on an abstract mixin page https://developer.mozilla.org/en-US/docs/Web/API/DocumentOrShadowRoot/activeElement

The BCD change happened in mdn/browser-compat-data#9045 (for the whole mixin).

Follow-up PRs for the other members coming.

@Elchi3 Elchi3 requested review from a team as code owners February 16, 2021 14:00
@Elchi3 Elchi3 requested review from chrisdavidmills and removed request for a team February 16, 2021 14:00
Copy link
Contributor

@chrisdavidmills chrisdavidmills left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This looks great, thanks @Elchi3 . I've done a couple of minor copy edits, but this looks ready to merge now.

And yes, I think this is a good way to divide up the PRs and make reviews manageable. Thanks for being so considerate.

@chrisdavidmills chrisdavidmills merged commit 55812d1 into mdn:main Feb 16, 2021
@Elchi3 Elchi3 deleted the demix-documentorshadowroot-activeElement branch February 16, 2021 15:26
@github-actions github-actions bot locked as resolved and limited conversation to collaborators Aug 27, 2022
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants