Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Document “AsyncGenerator” & “AsyncGeneratorFunction” #2861
Document “AsyncGenerator” & “AsyncGeneratorFunction” #2861
Changes from 11 commits
6de1a35
a8d56b1
ef06d6e
c1a2f09
cff7b5d
d38696c
77c1e75
15a51eb
658a2b4
ccfa77d
dddfb8a
ee4aca0
033ba8f
1ab12a5
76a0bb5
d58fe42
c331788
c6f5f6e
cf479a0
0c8af2e
0d1ab7a
f0be1e2
0786efa
File filter
Filter by extension
Conversations
Jump to
There are no files selected for viewing
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
This is a long and complicated sentence and could do with splitting into 2, probably at the "function and finishes" juncture. It's also not very clear how to parse "(or uncaught from)" or how that relates to "unless the exception is caught within that generator".
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Talking about next and finishes make me think, whether a state chart might be helpful for comprehension.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Is this the recommended or normal way to use this feature?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Do
eval()
-type warnings apply here? I found I couldn't execute the example in the console because of the CSP.There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Most likely.
This reads like a pendant to
new Function()
to be, which poses security vulnerabilities (esp. when running untrusted code).There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
{{jsxref("Statements/async_function*", "async generator function")}
is giving me broken links here and I guess elsewhere in the page.There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Also if "async generator function" here is English, not an identifier (which I think it is) it should start with an uppercase letter.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Is
{{jsxref("Statements/async_function*", "async function* expression")}
intended to have the same target as{{jsxref("Statements/async_function*", "async generator function")}
?There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Also here and throughout this file,
{{jsxref("Statements/async_function*", "async generator function")}
should be
{{jsxref("Statements/async_function*", "async generator function", "", "1")}
to suppress code formatting, which isn't appropriate here. See https://github.com/mdn/yari/blob/main/kumascript/macros/jsxref.ejs#L10.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Except for the final argument?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Again "async generator functions" should be "Async generator functions" if it's not an identifier.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
What does global scope refers to here (in context of an ES module, for example. Would other modules see it, as in, it were defined on
window
as property)?There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Double blank line 👀