Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Add stroke-* CSS SVG properties #35516

Merged
merged 9 commits into from
Aug 27, 2024
Merged

Add stroke-* CSS SVG properties #35516

merged 9 commits into from
Aug 27, 2024

Conversation

meyerweb
Copy link
Contributor

Description

Adds documentation for the CSS properties stroke-dasharray,stroke-dashoffset,stroke-linecap,stroke-linejoin,stroke-miterlimit,stroke-opacity, and stroke-width, almost all of which replicate SVG attributes. (stroke-miterlimit is similar to the corresponding SVG attribute, but not exactly the same.)

Motivation

The pages currently don’t exist, and need to be created (see #34763).

@meyerweb meyerweb requested review from a team as code owners August 19, 2024 20:45
@meyerweb meyerweb requested review from estelle and pepelsbey and removed request for a team August 19, 2024 20:45
@github-actions github-actions bot added Content:CSS Cascading Style Sheets docs Content:SVG SVG docs size/l [PR only] 501-1000 LoC changed labels Aug 19, 2024
@github-actions GitHub Actions
Copy link
Contributor

github-actions bot commented Aug 19, 2024 •
edited
Loading

Preview URLs (14 pages)

(comment last updated: 2024-08-26 19:37:54)

@Josh-Cena Josh-Cena linked an issue Aug 20, 2024 that may be closed by this pull request
Missing CSS properties defined in SVG #34763
Closed
30 tasks
@estelle
Copy link
Member

estelle commented Aug 20, 2024

i am reviewing it; but it's taking a while....

estelle
estelle requested changes Aug 21, 2024
View reviewed changes
Copy link
Member

@estelle estelle left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Review is at meyerweb#5

@pransh15
Copy link

Hi folks 👋
Thanks for starting with #34763!

I would like to understand the workflow here. I am confused since the feedback was shared in a PR on a fork(meyerweb#5).

@estelle
Copy link
Member

estelle commented Aug 22, 2024 •
edited
Loading

I would like to understand the workflow here. I am confused since the feedback was shared in a PR on a fork(meyerweb#5).

@pransh15
For large PRs, it is sometimes easier to provide suggested edits via a PR rather than via the GitHub GUI.
Another example is chrisdavidmills#10. Chris's PR was huge, and the PR feedback process went much faster there once we started using that method. This method makes sense only for XL PRs with tons of suggestions.

@pepelsbey pepelsbey removed their request for review August 22, 2024 10:06
@pransh15
Copy link

TIL! I understand that, thanks for clarifying @estelle. This was helpful. :)

@meyerweb
Copy link
Contributor Author

After going through Estelle’s edits and making a few small tweaks, this is again ready to be reviewed.

estelle
estelle approved these changes Aug 27, 2024
View reviewed changes
Copy link
Member

@estelle estelle left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

thank you!

@estelle estelle merged commit 4d23461 into mdn:main Aug 27, 2024
8 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@estelle estelle estelle approved these changes

Assignees
No one assigned
Labels
Content:CSS Cascading Style Sheets docs Content:SVG SVG docs size/l [PR only] 501-1000 LoC changed
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Missing CSS properties defined in SVG
3 participants
@meyerweb @estelle @pransh15