Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: flaws in web/javascript batch 7 #3584

Closed

Conversation

nschonni
Copy link
Contributor

No description provided.

@nschonni nschonni requested a review from a team as a code owner March 27, 2021 23:43
@nschonni nschonni requested review from wbamberg and removed request for a team March 27, 2021 23:43
@nschonni nschonni force-pushed the fix--flaws-in-web/javascript-batch-7 branch from 51454f5 to d799fbb Compare April 1, 2021 00:19
@nschonni nschonni force-pushed the fix--flaws-in-web/javascript-batch-7 branch from d799fbb to 8c29770 Compare April 5, 2021 22:14
@github-actions
Copy link
Contributor

github-actions bot commented Apr 5, 2021

Preview URLs

Flaws

URL: /en-US/docs/Web/JavaScript/Reference/Strict_mode
Title: Strict mode
on GitHub

No flaws! 🎉


URL: /en-US/docs/Web/JavaScript/Reference/Strict_mode/Transitioning_to_strict_mode
Title: Transitioning to strict mode
on GitHub

No flaws! 🎉


URL: /en-US/docs/Web/JavaScript/Reference/Operators/Right_shift
Title: Right shift (>>)
on GitHub

No flaws! 🎉


URL: /en-US/docs/Web/JavaScript/Reference/Operators/Unsigned_right_shift_assignment
Title: Unsigned right shift assignment (>>>=)
on GitHub

No flaws! 🎉


URL: /en-US/docs/Web/JavaScript/Reference/Operators/Logical_NOT
Title: Logical NOT (!)
on GitHub

No flaws! 🎉


URL: /en-US/docs/Web/JavaScript/Reference/Operators/Bitwise_NOT
Title: Bitwise NOT (~)
on GitHub

No flaws! 🎉


URL: /en-US/docs/Web/JavaScript/Reference/Operators/Bitwise_OR_assignment
Title: Bitwise OR assignment (|=)
on GitHub

No flaws! 🎉


URL: /en-US/docs/Web/JavaScript/Reference/Operators/Optional_chaining
Title: Optional chaining (?.)
on GitHub

No flaws! 🎉


URL: /en-US/docs/Web/JavaScript/Reference/Operators/Exponentiation_assignment
Title: Exponentiation assignment (**=)
on GitHub

No flaws! 🎉


URL: /en-US/docs/Web/JavaScript/Reference/Operators/Operator_Precedence
Title: Operator precedence
on GitHub

No flaws! 🎉


URL: /en-US/docs/Web/JavaScript/Reference/Operators/Assignment
Title: Assignment (=)
on GitHub

No flaws! 🎉


URL: /en-US/docs/Web/JavaScript/Reference/Operators/Left_shift_assignment
Title: Left shift assignment (<<=)
on GitHub

No flaws! 🎉


URL: /en-US/docs/Web/JavaScript/Reference/Operators/Destructuring_assignment
Title: Destructuring assignment
on GitHub

No flaws! 🎉


URL: /en-US/docs/Web/JavaScript/Reference/Operators/Nullish_coalescing_operator
Title: Nullish coalescing operator (??)
on GitHub

No flaws! 🎉


URL: /en-US/docs/Web/JavaScript/Reference/Operators/yield
Title: yield
on GitHub

No flaws! 🎉


URL: /en-US/docs/Web/JavaScript/Reference/Operators/typeof
Title: typeof
on GitHub

No flaws! 🎉


URL: /en-US/docs/Web/JavaScript/Reference/Operators/Bitwise_AND
Title: Bitwise AND (&)
on GitHub

No flaws! 🎉


URL: /en-US/docs/Web/JavaScript/Reference/Operators/Logical_AND
Title: Logical AND (&&)
on GitHub

No flaws! 🎉


URL: /en-US/docs/Web/JavaScript/Reference/Operators/Multiplication_assignment
Title: Multiplication assignment (*=)
on GitHub

No flaws! 🎉


URL: /en-US/docs/Web/JavaScript/Reference/Operators/Object_initializer
Title: Object initializer
on GitHub

No flaws! 🎉


URL: /en-US/docs/Web/JavaScript/Reference/Operators/Unsigned_right_shift
Title: Unsigned right shift (>>>)
on GitHub

No flaws! 🎉


URL: /en-US/docs/Web/JavaScript/Reference/Operators/Bitwise_XOR
Title: Bitwise XOR (^)
on GitHub

No flaws! 🎉


URL: /en-US/docs/Web/JavaScript/Reference/Operators/Property_Accessors
Title: Property accessors
on GitHub

No flaws! 🎉


URL: /en-US/docs/Web/JavaScript/Reference/Operators/delete
Title: delete operator
on GitHub

No flaws! 🎉


URL: /en-US/docs/Web/JavaScript/Reference/Operators/Division_assignment
Title: Division assignment (/=)
on GitHub

No flaws! 🎉


URL: /en-US/docs/Web/JavaScript/Reference/Operators/in
Title: in operator
on GitHub

No flaws! 🎉


URL: /en-US/docs/Web/JavaScript/Reference/Operators/function
Title: Function expression
on GitHub

No flaws! 🎉


URL: /en-US/docs/Web/JavaScript/Reference/Operators/Bitwise_XOR_assignment
Title: Bitwise XOR assignment (^=)
on GitHub

No flaws! 🎉


URL: /en-US/docs/Web/JavaScript/Reference/Operators/Right_shift_assignment
Title: Right shift assignment (>>=)
on GitHub

No flaws! 🎉


URL: /en-US/docs/Web/JavaScript/Reference/Operators/Exponentiation
Title: Exponentiation (**)
on GitHub

No flaws! 🎉


URL: /en-US/docs/Web/JavaScript/Reference/Operators/Remainder_assignment
Title: Remainder assignment (%=)
on GitHub

No flaws! 🎉


URL: /en-US/docs/Web/JavaScript/Reference/Operators/Left_shift
Title: Left shift (<<)
on GitHub

No flaws! 🎉


URL: /en-US/docs/Web/JavaScript/Reference/Operators/function*
Title: function* expression
on GitHub

No flaws! 🎉


URL: /en-US/docs/Web/JavaScript/Reference/Operators/Logical_OR
Title: Logical OR (||)
on GitHub

No flaws! 🎉


URL: /en-US/docs/Web/JavaScript/Reference/Operators/Bitwise_OR
Title: Bitwise OR (|)
on GitHub

No flaws! 🎉


URL: /en-US/docs/Web/JavaScript/Reference/Operators/yield*
Title: yield*
on GitHub

No flaws! 🎉


URL: /en-US/docs/Web/JavaScript/Reference/Operators/Bitwise_AND_assignment
Title: Bitwise AND assignment (&=)
on GitHub

No flaws! 🎉


URL: /en-US/docs/Web/JavaScript/Reference/Operators/Subtraction_assignment
Title: Subtraction assignment (-=)
on GitHub

No flaws! 🎉


URL: /en-US/docs/Web/JavaScript/Reference/Template_literals
Title: Template literals (Template strings)
on GitHub

No flaws! 🎉


URL: /en-US/docs/Web/JavaScript/Reference/Statements
Title: Statements and declarations
on GitHub
Flaw count: 2

  • macros:
    • /en-US/docs/Web/JavaScript/Reference/Statements/for_each...in does not exist
  • bad_bcd_links:
    • no explanation!

URL: /en-US/docs/Web/JavaScript/Reference/Statements/switch
Title: switch
on GitHub

No flaws! 🎉


URL: /en-US/docs/Web/JavaScript/Reference/Statements/let
Title: let
on GitHub

No flaws! 🎉


URL: /en-US/docs/Web/JavaScript/Reference/Statements/if...else
Title: if...else
on GitHub

No flaws! 🎉


URL: /en-US/docs/Web/JavaScript/Reference/Statements/for...of
Title: for...of
on GitHub
Flaw count: 6

  • macros:
    • /en-US/docs/Web/JavaScript/Reference/Global_Objects/Array/prototype does not exist
  • heading_links:
    • h3 heading contains an <a> tag
    • h3 heading contains an <a> tag
    • h3 heading contains an <a> tag
    • h3 heading contains an <a> tag
    • h3 heading contains an <a> tag

URL: /en-US/docs/Web/JavaScript/Reference/Statements/return
Title: return
on GitHub

No flaws! 🎉


URL: /en-US/docs/Web/JavaScript/Reference/Statements/while
Title: while
on GitHub

No flaws! 🎉


URL: /en-US/docs/Web/JavaScript/Reference/Statements/const
Title: const
on GitHub

No flaws! 🎉


URL: /en-US/docs/Web/JavaScript/Reference/Statements/with
Title: with
on GitHub
Flaw count: 2

  • macros:
    • /en-US/docs/Web/JavaScript/Reference/Global_Objects/Array/prototype does not exist
    • /en-US/docs/Web/JavaScript/Reference/Global_Objects/Array/prototype does not exist

URL: /en-US/docs/Web/JavaScript/Reference/Statements/throw
Title: throw
on GitHub

No flaws! 🎉

External URLs

URL: /en-US/docs/Web/JavaScript/Reference/Strict_mode
Title: Strict mode
on GitHub


URL: /en-US/docs/Web/JavaScript/Reference/Strict_mode/Transitioning_to_strict_mode
Title: Transitioning to strict mode
on GitHub


URL: /en-US/docs/Web/JavaScript/Reference/Operators/Right_shift
Title: Right shift (>>)
on GitHub


URL: /en-US/docs/Web/JavaScript/Reference/Operators/Unsigned_right_shift_assignment
Title: Unsigned right shift assignment (>>>=)
on GitHub


URL: /en-US/docs/Web/JavaScript/Reference/Operators/Logical_NOT
Title: Logical NOT (!)
on GitHub


URL: /en-US/docs/Web/JavaScript/Reference/Operators/Bitwise_NOT
Title: Bitwise NOT (~)
on GitHub


URL: /en-US/docs/Web/JavaScript/Reference/Operators/Bitwise_OR_assignment
Title: Bitwise OR assignment (|=)
on GitHub


URL: /en-US/docs/Web/JavaScript/Reference/Operators/Optional_chaining
Title: Optional chaining (?.)
on GitHub


URL: /en-US/docs/Web/JavaScript/Reference/Operators/Exponentiation_assignment
Title: Exponentiation assignment (**=)
on GitHub


URL: /en-US/docs/Web/JavaScript/Reference/Operators/Operator_Precedence
Title: Operator precedence
on GitHub

No external URLs

URL: /en-US/docs/Web/JavaScript/Reference/Operators/Assignment
Title: Assignment (=)
on GitHub


URL: /en-US/docs/Web/JavaScript/Reference/Operators/Left_shift_assignment
Title: Left shift assignment (<<=)
on GitHub


URL: /en-US/docs/Web/JavaScript/Reference/Operators/Destructuring_assignment
Title: Destructuring assignment
on GitHub


URL: /en-US/docs/Web/JavaScript/Reference/Operators/Nullish_coalescing_operator
Title: Nullish coalescing operator (??)
on GitHub


URL: /en-US/docs/Web/JavaScript/Reference/Operators/yield
Title: yield
on GitHub


URL: /en-US/docs/Web/JavaScript/Reference/Operators/typeof
Title: typeof
on GitHub


URL: /en-US/docs/Web/JavaScript/Reference/Operators/Bitwise_AND
Title: Bitwise AND (&)
on GitHub


URL: /en-US/docs/Web/JavaScript/Reference/Operators/Logical_AND
Title: Logical AND (&&)
on GitHub


URL: /en-US/docs/Web/JavaScript/Reference/Operators/Multiplication_assignment
Title: Multiplication assignment (*=)
on GitHub


URL: /en-US/docs/Web/JavaScript/Reference/Operators/Object_initializer
Title: Object initializer
on GitHub


URL: /en-US/docs/Web/JavaScript/Reference/Operators/Unsigned_right_shift
Title: Unsigned right shift (>>>)
on GitHub


URL: /en-US/docs/Web/JavaScript/Reference/Operators/Bitwise_XOR
Title: Bitwise XOR (^)
on GitHub


URL: /en-US/docs/Web/JavaScript/Reference/Operators/Property_Accessors
Title: Property accessors
on GitHub


URL: /en-US/docs/Web/JavaScript/Reference/Operators/delete
Title: delete operator
on GitHub


URL: /en-US/docs/Web/JavaScript/Reference/Operators/Division_assignment
Title: Division assignment (/=)
on GitHub


URL: /en-US/docs/Web/JavaScript/Reference/Operators/in
Title: in operator
on GitHub


URL: /en-US/docs/Web/JavaScript/Reference/Operators/function
Title: Function expression
on GitHub


URL: /en-US/docs/Web/JavaScript/Reference/Operators/Bitwise_XOR_assignment
Title: Bitwise XOR assignment (^=)
on GitHub


URL: /en-US/docs/Web/JavaScript/Reference/Operators/Right_shift_assignment
Title: Right shift assignment (>>=)
on GitHub


URL: /en-US/docs/Web/JavaScript/Reference/Operators/Exponentiation
Title: Exponentiation (**)
on GitHub


URL: /en-US/docs/Web/JavaScript/Reference/Operators/Remainder_assignment
Title: Remainder assignment (%=)
on GitHub


URL: /en-US/docs/Web/JavaScript/Reference/Operators/Left_shift
Title: Left shift (<<)
on GitHub


URL: /en-US/docs/Web/JavaScript/Reference/Operators/function*
Title: function* expression
on GitHub


URL: /en-US/docs/Web/JavaScript/Reference/Operators/Logical_OR
Title: Logical OR (||)
on GitHub


URL: /en-US/docs/Web/JavaScript/Reference/Operators/Bitwise_OR
Title: Bitwise OR (|)
on GitHub


URL: /en-US/docs/Web/JavaScript/Reference/Operators/yield*
Title: yield*
on GitHub


URL: /en-US/docs/Web/JavaScript/Reference/Operators/Bitwise_AND_assignment
Title: Bitwise AND assignment (&=)
on GitHub


URL: /en-US/docs/Web/JavaScript/Reference/Operators/Subtraction_assignment
Title: Subtraction assignment (-=)
on GitHub


URL: /en-US/docs/Web/JavaScript/Reference/Template_literals
Title: Template literals (Template strings)
on GitHub


URL: /en-US/docs/Web/JavaScript/Reference/Statements
Title: Statements and declarations
on GitHub


URL: /en-US/docs/Web/JavaScript/Reference/Statements/switch
Title: switch
on GitHub


URL: /en-US/docs/Web/JavaScript/Reference/Statements/let
Title: let
on GitHub


URL: /en-US/docs/Web/JavaScript/Reference/Statements/if...else
Title: if...else
on GitHub


URL: /en-US/docs/Web/JavaScript/Reference/Statements/for...of
Title: for...of
on GitHub


URL: /en-US/docs/Web/JavaScript/Reference/Statements/return
Title: return
on GitHub


URL: /en-US/docs/Web/JavaScript/Reference/Statements/while
Title: while
on GitHub


URL: /en-US/docs/Web/JavaScript/Reference/Statements/const
Title: const
on GitHub


URL: /en-US/docs/Web/JavaScript/Reference/Statements/with
Title: with
on GitHub


URL: /en-US/docs/Web/JavaScript/Reference/Statements/throw
Title: throw
on GitHub

@nschonni
Copy link
Contributor Author

@wbamberg any issues with this one?

Copy link
Collaborator

@wbamberg wbamberg left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks @nschonni ! I just had one comment here.

@@ -291,7 +291,7 @@ <h3 id="Difference_between_for...of_and_for...in">Difference between <code>for..

<p>Every object will inherit the <code>objCustom</code> property and every object that is
an {{jsxref("Array")}} will inherit the <code>arrCustom</code> property since these
properties have been added to {{jsxref("Object.prototype")}} and
properties have been added to {{jsxref("Object")}} and
Copy link
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This should probably keep the previous link text Object.prototype, or the sentence doesn't really make sense (I think this might be a pattern in these PRs, and one that I've probably missed sometimes - if changing the jsxref firstargument, it's worth considering whether we should provide the second argument to set link text independently.

I wonder why {{jsxref("Array.prototype")}} isn't a flaw, that page doesn't exist.

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

So you're thinking {{jsxref("Object", "Object.prototype")}} or maybe just dropping the jsxref

@nschonni nschonni closed this May 13, 2021
@nschonni nschonni deleted the fix--flaws-in-web/javascript-batch-7 branch May 3, 2022 05:35
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants