-
Notifications
You must be signed in to change notification settings - Fork 22.5k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
fix: flaws in web/javascript batch 7 #3584
Conversation
51454f5
to
d799fbb
Compare
d799fbb
to
8c29770
Compare
@wbamberg any issues with this one? |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Thanks @nschonni ! I just had one comment here.
@@ -291,7 +291,7 @@ <h3 id="Difference_between_for...of_and_for...in">Difference between <code>for.. | |||
|
|||
<p>Every object will inherit the <code>objCustom</code> property and every object that is | |||
an {{jsxref("Array")}} will inherit the <code>arrCustom</code> property since these | |||
properties have been added to {{jsxref("Object.prototype")}} and | |||
properties have been added to {{jsxref("Object")}} and |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
This should probably keep the previous link text Object.prototype
, or the sentence doesn't really make sense (I think this might be a pattern in these PRs, and one that I've probably missed sometimes - if changing the jsxref firstargument, it's worth considering whether we should provide the second argument to set link text independently.
I wonder why {{jsxref("Array.prototype")}}
isn't a flaw, that page doesn't exist.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
So you're thinking {{jsxref("Object", "Object.prototype")}}
or maybe just dropping the jsxref
No description provided.